A_StartSound startTime

[Rachael]

https://github.com/coelckers/gzdoom/pull/1047

This allows to start a sound at an arbitrary position, instead of always at the beginning. This is a port of Nash's work from the older sound code before the ZMusic refactor.

Nash's sample mod for this is here. (old sample, will not work anymore, see attachment)

Based on Nash's sample, I also updated it to use A_StartSound for the test, as well, since A_PlaySound got deprecated:

a_playsound_start_time_test-2.zip

(17.39 KiB) Downloaded 60 times

[Graf Zahl]

Why did you add the new parameter to the deprecated A_PlaySound function? Let's keep it deprecated and not expand it.

[Rachael]

Sorry - it was this PR's roots... it originated before the deprecation. Will remove.

[Nash]

Yeah, the old one was made before the A_StartSound deprecation. Rachael's implementation is new.

[Graf Zahl]

It looks like it was removed from the wrong function internally, the change seems to be on A_StartSound, not A_PlaySound

[Rachael]

Oh, that'll show me to code before bedtime...

Fixed.

[Graf Zahl]

Did you forget to push?

[Rachael]

Oops, seems I did.

[Rip and Tear]

It may be worth having a special value (-1?) that starts the sound at the sound's LOOP_START marker (https://zdoom.org/wiki/Audio_loop)