ACS string table corruption
Moderator: GZDoom Developers
Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
- Marrub
-
- Posts: 1193
- Joined: Tue Feb 26, 2013 2:48 pm
- Preferred Pronouns: No Preference
- Operating System Version (Optional): Arch Linux
- Graphics Processor: ATI/AMD with Vulkan/Metal Support
- Contact:
ACS string table corruption
Summary 0000590
ACS string table corruption
Description
Same as issue 0000441 but, apparently, it's not save games causing this. Strings are just getting shuffled around in the string table, for some reason.
Additional Information
The attached save file uses doom2.wad and http://mab.greyserv.net/f/Lithium_1_4.pk7
Files
save30.zds
ACS string table corruption
Description
Same as issue 0000441 but, apparently, it's not save games causing this. Strings are just getting shuffled around in the string table, for some reason.
Additional Information
The attached save file uses doom2.wad and http://mab.greyserv.net/f/Lithium_1_4.pk7
Files
save30.zds
- Marrub
-
- Posts: 1193
- Joined: Tue Feb 26, 2013 2:48 pm
- Preferred Pronouns: No Preference
- Operating System Version (Optional): Arch Linux
- Graphics Processor: ATI/AMD with Vulkan/Metal Support
- Contact:
Re: 0000590: ACS string table corruption
Forgot to add, the save is running 2.4.0. (Though that could be determined by just looking inside the file.)
You can reproduce the issue by grabbing the plasma rifle in front of the player, but there's also corrupted strings in the log tab in the menu.
You can reproduce the issue by grabbing the plasma rifle in front of the player, but there's also corrupted strings in the log tab in the menu.
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49067
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: 0000590: ACS string table corruption
Sorry, but this is pretty much undebuggable.
The biggest roadblock are those ACS binaries which I cannot decompile or disassemble to rule out bad code generation as a culprit. To use dynamic strings from ACS libraries they need to follow very strict procedures of how to deal with strings. So far every time someone reported string corruption it was caused by badly generated byte code.
I need something smaller and more contained where I am capable of seeing what the scripts are actually doing. This is 1.8 MB of ACS binary code, all of which may indirectly be responsible for the problems.
The biggest roadblock are those ACS binaries which I cannot decompile or disassemble to rule out bad code generation as a culprit. To use dynamic strings from ACS libraries they need to follow very strict procedures of how to deal with strings. So far every time someone reported string corruption it was caused by badly generated byte code.
I need something smaller and more contained where I am capable of seeing what the scripts are actually doing. This is 1.8 MB of ACS binary code, all of which may indirectly be responsible for the problems.
- wildweasel
- Posts: 21706
- Joined: Tue Jul 15, 2003 7:33 pm
- Preferred Pronouns: He/Him
- Operating System Version (Optional): A lot of them
- Graphics Processor: Not Listed
- Contact:
Re: ACS string table corruption
I'd like to amend this report by saying that FInal Doomer Plus (found at viewtopic.php?f=43&t=55061) also exhibits this glitch; weapon descriptions (invoked by holding Reload) will sometimes change into a letter A. I'd managed to trigger this with the Plutonia machine gun, but don't have a save file handy ([edit]: for what it's worth, though, it may have exhibited by use of autosaves).
- Marrub
-
- Posts: 1193
- Joined: Tue Feb 26, 2013 2:48 pm
- Preferred Pronouns: No Preference
- Operating System Version (Optional): Arch Linux
- Graphics Processor: ATI/AMD with Vulkan/Metal Support
- Contact:
Re: ACS string table corruption
Yeah, a lot of people are getting this bug, and the code is maybe 60 lines of vanilla ACS... That's kind of worrying.
- phantombeta
- Posts: 2088
- Joined: Thu May 02, 2013 1:27 am
- Operating System Version (Optional): Windows 10
- Graphics Processor: nVidia with Vulkan support
- Location: Brazil
Re: ACS string table corruption
Wasn't this one fixed?
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49067
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: ACS string table corruption
It probably is - then again - maybe not. Who knows if it was the same thing, like I said this was undebuggable.
- phantombeta
- Posts: 2088
- Joined: Thu May 02, 2013 1:27 am
- Operating System Version (Optional): Windows 10
- Graphics Processor: nVidia with Vulkan support
- Location: Brazil
Re: ACS string table corruption
It was most definitely the exact same bug Final Doomer had, there's literally zero doubt about that.Graf Zahl wrote:It probably is - then again - maybe not. Who knows if it was the same thing, like I said this was undebuggable.
Re: ACS string table corruption
Most likely, it was this bug. I don't remember that something like this was reported after the given change.