Typo in lights.pk3

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
User avatar
Marisa the Magician
Posts: 3886
Joined: Fri Feb 08, 2008 9:15 am
Preferred Pronouns: She/Her
Operating System Version (Optional): (btw I use) Arch
Graphics Processor: nVidia with Vulkan support
Location: Vigo, Galicia
Contact:

Typo in lights.pk3

Post by Marisa the Magician »

While playing Heretic some days back I noticed something odd in the D'Sparil fight. The Serpent's fireballs had a really broken light with a massive flicker radius. I traced it down to this.

Code: Select all

// D'Sparil serpent fireball
flickerlight SERPENTBALL
{
    color 1.0 0.95 0.5
    size 588
    secondarySize 96
    chance 0.5
	attenuate 1
}
Pretty sure that size should be 88. Seems like this has been a thing for over two years and no one has noticed? The commit where it happened is this.
User avatar
Rachael
Posts: 13530
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Typo in lights.pk3

Post by Rachael »

User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Typo in lights.pk3

Post by Graf Zahl »

Amazing what kind of stuff goes unnoticed for so long...
User avatar
Enjay
 
 
Posts: 26517
Joined: Tue Jul 15, 2003 4:58 pm
Location: Scotland
Contact:

Re: Typo in lights.pk3

Post by Enjay »

In this case, it probably shows how few people play Heretic, or at least Heretic maps with D'Sparil in them.

I just checked out my own lights definition that I updated from the previous non-attenuated values and I'd set it to 84 myself. Not saying that's better (the difference would be barely noticeable - much less than a difference of 500 anyway) more that my own calculation got it pretty close to the intended official 88.
Gez
 
 
Posts: 17833
Joined: Fri Jul 06, 2007 3:22 pm

Re: Typo in lights.pk3

Post by Gez »

D'Sparil is typically fought in wide open-sky areas that are brightly lit, so the effect of dynlights is less pronounced that when they happen in small, dark corners.
Post Reply

Return to “Closed Bugs [GZDoom]”