[ae57bc7] Manually spawned dynlights don't work
Moderator: GZDoom Developers
Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
- Marisa the Magician
- Posts: 3886
- Joined: Fri Feb 08, 2008 9:15 am
- Preferred Pronouns: She/Her
- Operating System Version (Optional): (btw I use) Arch
- Graphics Processor: nVidia with Vulkan support
- Location: Vigo, Galicia
- Contact:
[ae57bc7] Manually spawned dynlights don't work
Since this commit any dynamic light actors that are spawned won't work unless one disables and re-enables dynamic lights in the options. This breaks a wide variety of mods.
Re: [ae57bc7] Manually spawned dynlights don't work
Made this PR with the fix. Honestly, overall dynamic light setup is quite fragile. There are two pretty distinct ways to create them. C++ side has not so trivial blend of both ways though.
- Marisa the Magician
- Posts: 3886
- Joined: Fri Feb 08, 2008 9:15 am
- Preferred Pronouns: She/Her
- Operating System Version (Optional): (btw I use) Arch
- Graphics Processor: nVidia with Vulkan support
- Location: Vigo, Galicia
- Contact:
Re: [ae57bc7] Manually spawned dynlights don't work
This fix still hasn't been added?
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49067
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: [ae57bc7] Manually spawned dynlights don't work
I haven't had time yet to review it.
- drfrag
- Vintage GZDoom Developer
- Posts: 3141
- Joined: Fri Apr 23, 2004 3:51 am
- Location: Spain
- Contact:
Re: [ae57bc7] Manually spawned dynlights don't work
This bug looks important, what about that PR?
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49067
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: [ae57bc7] Manually spawned dynlights don't work
Sorry, I've been busy elsewhere the last few days. _mental_ made some remarks in the PR I first need to check before applying it.
- Marisa the Magician
- Posts: 3886
- Joined: Fri Feb 08, 2008 9:15 am
- Preferred Pronouns: She/Her
- Operating System Version (Optional): (btw I use) Arch
- Graphics Processor: nVidia with Vulkan support
- Location: Vigo, Galicia
- Contact:
Re: [ae57bc7] Manually spawned dynlights don't work
I've been using that PR for a week now and it doesn't seem to cause any issues.
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49067
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: [ae57bc7] Manually spawned dynlights don't work
I know that it works, that's not the problem. But I cannot apply a PR if that PR also hints at something wrong at a deeper level.
- drfrag
- Vintage GZDoom Developer
- Posts: 3141
- Joined: Fri Apr 23, 2004 3:51 am
- Location: Spain
- Contact:
Re: [ae57bc7] Manually spawned dynlights don't work
I just wanted to be sure you didn't forget as you were doing other stuff.
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49067
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: [ae57bc7] Manually spawned dynlights don't work
I went ahead and merged it, it's unlikely that I'd do some deeper investigation in the near future anyway.