[Fixed] [4.0.0] Where's the "Ouch" face?

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Re: [4.0.0] Where's the "Ouch" face?

Postby Player701 » Sat Jun 08, 2019 6:03 am

I wish I did... I'd have submitted a PR long ago if I did... :( That part of code is quite a mess indeed, so I'm too afraid that I'd break something else if I tried to fix it.

Sorry again.
User avatar
Player701
You are now breathing manually.
 
Joined: 13 May 2009
Location: Russian Federation
Discord: Player701#8214

Re: [4.0.0] Where's the "Ouch" face?

Postby Graf Zahl » Sat Jun 08, 2019 6:05 am

Player701 wrote:That part of code is quite a mess indeed, so I'm too afraid I'd break something else if I tried to fix it.


Welcome to the club! I think you'll understand why something this seemingly trivial doesn't get fixed. The entire setup depended on broken code to have side effects.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [4.0.0] Where's the "Ouch" face?

Postby Graf Zahl » Fri Aug 09, 2019 2:59 am

Fixed. This needed a little bit of contortions to ensure that the health values being compared are properly synchronized. For that they must both be set in the same function.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [4.0.0] Where's the "Ouch" face?

Postby Player701 » Fri Aug 09, 2019 3:01 am

Yay! Thank you very much Graf :D
User avatar
Player701
You are now breathing manually.
 
Joined: 13 May 2009
Location: Russian Federation
Discord: Player701#8214

Previous

Return to Closed Bugs

Who is online

Users browsing this forum: Ahrefs [Bot] and 1 guest