[Added] Pitch tuning in A_PlaySound/A_PlaySoundEX

Moderator: GZDoom Developers

Re: Sound Pitch Setting/Adjusting

Postby Graf Zahl » Wed Jul 24, 2019 1:07 am

This will be merged once Chris has made a review. I cannot judge if it is ok.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Pitch tuning in A_PlaySound/A_PlaySoundEX

Postby Rachael » Wed Jul 24, 2019 8:32 am

@Cooke: I merged your pull request thread. There's really no need to make a separate thread.

If you think Graf isn't going to notice, give him some time and see if he does, and then you cna post a reminder in the dev forum.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Pitch tuning in A_PlaySound/A_PlaySoundEX

Postby Major Cooke » Wed Jul 24, 2019 8:48 am

Understood. Anyway I'm working with Chris on this now.
User avatar
Major Cooke
QZDoom Maintenance Team
 
Joined: 28 Jan 2007

Re: Pitch tuning in A_PlaySound/A_PlaySoundEX

Postby Rachael » Wed Jul 24, 2019 8:59 am

Oh also obviously - if you do make a pull request, make sure to remind us in your post to please move it to the code submissions section. ;) Moderators can do it too, so reporting it is fine.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Pitch tuning in A_PlaySound/A_PlaySoundEX

Postby Major Cooke » Wed Jul 24, 2019 10:27 am

Alright.

@Graf: Chris has completed his work. And I've squashed it down into one commit so it's clean.
User avatar
Major Cooke
QZDoom Maintenance Team
 
Joined: 28 Jan 2007

Previous

Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 4 guests