[Added] F3DFloor exporting

Moderator: GZDoom Developers

F3DFloor exporting

Postby Marisa Kirisame » Sun Sep 16, 2018 8:08 am

Pull Request

I should have opened a thread for this long ago. This is one part of allowing access to 3D Floor structs and other related functionality. The other part involves some data structures I haven't quite figured out how to expose (extra sector data like light lists or fake floor arrays).
User avatar
Marisa Kirisame
ZScript Magician
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: 霧雨魔理沙#1666
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: F3DFloor exporting [Part 1]

Postby Graf Zahl » Sun Sep 16, 2018 10:01 am

I first have to make sure that this won't get in the way of needed refactorings for Vulkan.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: F3DFloor exporting [Part 1]

Postby Marisa Kirisame » Mon Feb 04, 2019 8:53 am

I've decided to close this temporarily while I come up with something cleaner and more usable (and less intrusive). Will open a new PR once I have things ready.

Edit: PR opened.
User avatar
Marisa Kirisame
ZScript Magician
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: 霧雨魔理沙#1666
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: F3DFloor exporting [Part 1]

Postby Marisa Kirisame » Fri Mar 08, 2019 4:58 am

Just wanted to ask if this is still going to be a problem for vulkan or anything. The data exposed is entirely read-only just in case.
User avatar
Marisa Kirisame
ZScript Magician
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: 霧雨魔理沙#1666
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: F3DFloor exporting [Part 1]

Postby Marisa Kirisame » Sun Apr 21, 2019 12:02 pm

Shamelessly bumping this. I haven't heard anything in a while.
User avatar
Marisa Kirisame
ZScript Magician
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: 霧雨魔理沙#1666
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: F3DFloor exporting [Part 1]

Postby Graf Zahl » Sun Apr 21, 2019 1:01 pm

Totally not a priority right now.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: F3DFloor exporting [Part 1]

Postby Major Cooke » Wed Jul 03, 2019 12:24 pm

Huh... I've encountered a point where I'll actually need this to continue what I'm working on.
User avatar
Major Cooke
Do unto others as you would have unto you. Judge yourself first.
 
Joined: 28 Jan 2007

Re: F3DFloor exporting [Part 1]

Postby Marisa Kirisame » Sat Jul 06, 2019 4:04 am

So, I guess it is happening, then. There is now a demand for it from more people than just me.
User avatar
Marisa Kirisame
ZScript Magician
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: 霧雨魔理沙#1666
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: F3DFloor exporting [Part 1]

Postby Rachael » Sat Jul 06, 2019 4:26 am

If _mental_ or dpJudas take a look at it and if they don't anticipate any problems, then I think this can be merged.

What would probably really help this along, though, is having some bare-minimum test samples to ensure everything works correctly.

Of course, Graf can also just merge or reject this on a whim, as well, if the mood ever struck him or he wanted to.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Graphics Processor: nVidia with Vulkan support

Re: F3DFloor exporting [Part 1]

Postby dpJudas » Sat Jul 06, 2019 4:32 am

I don't know enough about this part of GZDoom or Doom mapping to evaluate it, nor do I have an interest in learning it - sorry. :)
dpJudas
 
 
 
Joined: 28 May 2016

Re: F3DFloor exporting [Part 1]

Postby Marisa Kirisame » Sat Jul 06, 2019 7:45 am

Rachael wrote:What would probably really help this along, though, is having some bare-minimum test samples to ensure everything works correctly.


In my case I've been making sure it all works through the experimental branch of doom tournament. The biorifle and flak cannon need direct 3d floor data access for projectile alignment and custom bounce behavior, respectively.

In the PR's current state I've verified that all works correctly on maps with sloped 3d floors, despite a small bug/glitch that is unrelated to this PR which I'll report later (projectiles and hitscans may sometimes "phase through" sloped 3d floors if they're too thin).
User avatar
Marisa Kirisame
ZScript Magician
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: 霧雨魔理沙#1666
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: F3DFloor exporting [Part 1]

Postby Major Cooke » Wed Jul 10, 2019 9:59 am

Looks like this is coming along nicely now. Marisa has made those requested changes too, I'm stoked! :mrgreen:

Speaking of custom bounce behavior, Marisa, I've been in desperate need for finding out how to make projectiles not just explode on sloped floors. Where can I find the code for this?
User avatar
Major Cooke
Do unto others as you would have unto you. Judge yourself first.
 
Joined: 28 Jan 2007

Re: F3DFloor exporting [Part 1]

Postby Marisa Kirisame » Wed Jul 10, 2019 12:02 pm

I'm afraid that's another bug unrelated to this. Though it may be related to the one of projectiles/traces phasing through them.
User avatar
Marisa Kirisame
ZScript Magician
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: 霧雨魔理沙#1666
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: F3DFloor exporting [Part 1]

Postby Marisa Kirisame » Wed Jul 24, 2019 5:39 am

So... any chance this can get a final review?
User avatar
Marisa Kirisame
ZScript Magician
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: 霧雨魔理沙#1666
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: F3DFloor exporting [Part 1]

Postby Graf Zahl » Wed Jul 24, 2019 6:51 am

If someone else can do it?
Sorry, I don't have much time to do real programming work on GZDoom and that's unlikely to change until the end of August.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Next

Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 4 guests