Version Mismatch text change

Moderator: GZDoom Developers

Post Reply
User avatar
Major Cooke
Posts: 8170
Joined: Sun Jan 28, 2007 3:55 pm
Preferred Pronouns: He/Him
Location: QZDoom Maintenance Team

Version Mismatch text change

Post by Major Cooke »

Pull Request

Because I keep getting the same question over and over again with my mods:
Many people wrote:What's this <x> expected and only <y> supported? I have <x> though!
I know that won't change anything in the short term, but as time goes on and new versions come out, that should hopefully fade off...
User avatar
drfrag
Vintage GZDoom Developer
Posts: 3141
Joined: Fri Apr 23, 2004 3:51 am
Location: Spain
Contact:

Re: Version Mismatch text change

Post by drfrag »

AFAIK ZScript and engine versions don't need to match. Besides i think you put them backwards.
User avatar
Major Cooke
Posts: 8170
Joined: Sun Jan 28, 2007 3:55 pm
Preferred Pronouns: He/Him
Location: QZDoom Maintenance Team

Re: Version Mismatch text change

Post by Major Cooke »

ZScript and GZDoom engine versions have been set to match for a while now. Also fixed.
Last edited by Major Cooke on Sun Jun 30, 2019 5:27 pm, edited 1 time in total.
User avatar
phantombeta
Posts: 2084
Joined: Thu May 02, 2013 1:27 am
Operating System Version (Optional): Windows 10
Graphics Processor: nVidia with Vulkan support
Location: Brazil

Re: Version Mismatch text change

Post by phantombeta »

Major Cooke wrote:ZScript and GZDoom engine versions have been set to match for a while now. Also amusingly, it's been backwards for a while it seems.
That's not backwards. The mod expects 4.0.0 or higher, while the version of GZDoom is 3.5.1. Your PR, meanwhile, is actually backwards. It'd print

Code: Select all

Version mismatch. GZDoom 4.0.0 is incompatible with at least one file. Version 3.5.1 or later is required.
Which is obviously wrong.
User avatar
Major Cooke
Posts: 8170
Joined: Sun Jan 28, 2007 3:55 pm
Preferred Pronouns: He/Him
Location: QZDoom Maintenance Team

Re: Version Mismatch text change

Post by Major Cooke »

Sadly I didn't finish the edit until after you did. At any rate it's all fixed.
User avatar
Rachael
Posts: 13531
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Version Mismatch text change

Post by Rachael »

drfrag wrote:AFAIK ZScript and engine versions don't need to match. Besides i think you put them backwards.
This is correct.
Major Cooke wrote:ZScript and GZDoom engine versions have been set to match for a while now.
Irrelevant. It's talking about the ZScript version, not the GZDoom version.

This PR basically creates an inherent misnomer, even if the ZScript version happened to match the GZDoom version all this time. It does not take into account child ports, which do not follow GZDoom's versioning scheme.

So yeah - this is not mergeable as-is.

Please rephrase it accordingly.
User avatar
Rachael
Posts: 13531
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Version Mismatch text change

Post by Rachael »

I added this but with major changes in this commit.
User avatar
Major Cooke
Posts: 8170
Joined: Sun Jan 28, 2007 3:55 pm
Preferred Pronouns: He/Him
Location: QZDoom Maintenance Team

Re: Version Mismatch text change

Post by Major Cooke »

That's plenty good for me.
Post Reply

Return to “Closed Feature Suggestions [GZDoom]”