Missing newline in PrintMiscActorInfo()

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
Blue Shadow
Posts: 4949
Joined: Sun Nov 14, 2010 12:59 am

Missing newline in PrintMiscActorInfo()

Post by Blue Shadow »

A "\n" is missing in this line in PrintMiscActorInfo().
User avatar
Rachael
Posts: 13575
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Missing newline in PrintMiscActorInfo()

Post by Rachael »

User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49073
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Missing newline in PrintMiscActorInfo()

Post by Graf Zahl »

What editor did you use? This added an UTF-8 BOM marker to the file which some compilers do not like.
User avatar
Rachael
Posts: 13575
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Missing newline in PrintMiscActorInfo()

Post by Rachael »

Ugh. Notepad.

But... what are the Unicode characters in this file doing, then? It doesn't do that unless they are there.

EDIT: Nevermind, saved it as an ANSI file with the plan to do a 'git diff' on it to see what changed - and nothing did. No idea what Microsoft did to this thing, but it should not be adding BOMs to files randomly like that.
dpJudas
 
 
Posts: 3044
Joined: Sat May 28, 2016 1:01 pm

Re: Missing newline in PrintMiscActorInfo()

Post by dpJudas »

Notepad has always added BOM to unicode files. It is essentially how it knows a file is unicode vs ansi. It was one of those early ideas in the unicode standard that went out of favor, and in typical Microsoft fashion once something has been decided it can't be changed until it should have been done over 10 years ago. :)
User avatar
Rachael
Posts: 13575
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Missing newline in PrintMiscActorInfo()

Post by Rachael »

It only did that when Unicode characters were present though - and in earlier versions (such as what's in Windows 8) it would give you a warning, as well. In the recent versions of Windows 10 it does not even bother with the warning anymore.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49073
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Missing newline in PrintMiscActorInfo()

Post by Graf Zahl »

Lesson of the day: Do not use Notepad! Do yourself a favor and install something decent, like Notepad++.

Yes, Microsoft seems to have had issues with UTF-8 detection in the past, the first iteration in Visual Studio was also totally unusable and AFAIK only fixed after having received massive criticism.
User avatar
Rachael
Posts: 13575
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Missing newline in PrintMiscActorInfo()

Post by Rachael »

I have Notepad2 thanks to TortoiseGit, but it's a lot easier to just type "notepad" on the command line than "notepad2". (I use the command line almost exclusively, nearly 99% of the time)

And I just haven't had much reason yet to create a redirection program that allows me to automatically switch to it when I type notepad.
Post Reply

Return to “Closed Bugs [GZDoom]”