MAPINFO lightmode 16 doesn't work g4.2pre-142-g324a720d5
Moderator: GZDoom Developers
Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
MAPINFO lightmode 16 doesn't work g4.2pre-142-g324a720d5
When setting a map's "lightmode" property to 16 (Vanilla), the map just ends up getting the "Software" lighting instead. It seems that lightmode 16 via MAPINFO just does not work.
- Attachments
-
- LightModeTest.pk3
- (3.8 KiB) Downloaded 32 times
Re: MAPINFO lightmode 16 doesn't work g4.2pre-142-g324a720d5
I have updated the OP with a test file. Goes without saying that your current lightmode user setting (in the Options menu) must be set to something else other than Vanilla to actually see that the feature isn't working.
Re: MAPINFO lightmode 16 doesn't work g4.2pre-142-g324a720d5
While those assumptions are correct, what really happens is that MAPINFO lightmode gets ignored only for setting 16. For other lightmodes, (all of them up to 8), it works exactly as your assumption - meaning, the MAPINFO override value is used, and changing the CVar has no effect.
But when lightmode 16 specifically is used as a MAPINFO override, lightmode 8 gets enforced in the game view.
But when lightmode 16 specifically is used as a MAPINFO override, lightmode 8 gets enforced in the game view.
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49056
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: MAPINFO lightmode 16 doesn't work g4.2pre-142-g324a720d5
This is due to how the lightmodes get checked. The light mode doesn't get passed to the shader directly, it is only being used for calculating light levels on the CPU side, but for software lighting this must be done in the shader. And this value wasn't properly set up because apparently when implementing this, it was overlooked that the light mode can not only be set by the CVAR but also through MAPINFO.
- drfrag
- Vintage GZDoom Developer
- Posts: 3141
- Joined: Fri Apr 23, 2004 3:51 am
- Location: Spain
- Contact:
Re: MAPINFO lightmode 16 doesn't work g4.2pre-142-g324a720d5
This can't be fixed in the legacy build AFAIK, no big deal tough. I missed the MAPINFO part hidden in "- use symbolic constants for the light modes." since there were a lot of conflicts.
Back then lightmode was in level_info_t and not in HWDrawInfo.
Back then lightmode was in level_info_t and not in HWDrawInfo.
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49056
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: MAPINFO lightmode 16 doesn't work g4.2pre-142-g324a720d5
Forget it. The software light modes are hardly relevant for hardware that have no shader support. Those on better hardware shouldn't use the legacy builds anyway.
- drfrag
- Vintage GZDoom Developer
- Posts: 3141
- Joined: Fri Apr 23, 2004 3:51 am
- Location: Spain
- Contact:
Re: MAPINFO lightmode 16 doesn't work g4.2pre-142-g324a720d5
That's what i'm going to do, it's this commit in the middle of the level refactor: "- changed light mode handling of the hardware renderer so that it only operates on local copies but doesn't alter the level's setting."
No big deal, ZD software it's used instead.
No big deal, ZD software it's used instead.