[Fixed] [GZDoom 4.1.2] Vulkan Crashes "AMD 400/500 Series"

[MasterBeavis]

im just glad you narrowed it down more lol

[Dwailing]

im just glad you narrowed it down more lol

You're the one who got me looking into Display settings, and you were right about it being something in post-processing. I just started trying settings until something broke, lol. You'd probably have gotten there. More than anything I'm glad I was able to corroborate the issue. Would have been bad if this got written off as just a problem with your hardware.

[Rachael]

Vulkan is disabled on the 32 bit builds, so that's why it doesn't crash. This doesn't really mean anything.

[MasterBeavis]

Vulkan is disabled on the 32 bit builds, so that's why it doesn't crash. This doesn't really mean anything.

Yea we already figured that out lol its Bloom in Post Processing with Vulkan thats causing it

[dpJudas]

More than anything I'm glad I was able to corroborate the issue

Yes, thanks once again in confirming this bug report. And thanks for narrowing it down the bloom pass and seemingly related to load/save code (save game thumbnail, most likely). It will help figuring out what could be causing it.

[dpJudas]

Okay, I pushed a commit that I think may fix the issue reported here. Please test again with the next nightly build.

[MasterBeavis]

nope still crashed https://ci.appveyor.com/project/coelcke ... 3r7ou4n6bc

[dpJudas]

Oh well. I don't have a clue what is causing the crash then.

[_mental_]

With this fix I managed to reproduce the crash on Vega occasionally. It's somewhere inside vkCmdBeginRenderPass function.

---

Code: Select all • Expand view

VulkanCommandBuffer::beginRenderPass(const VkRenderPassBeginInfo * pRenderPassBegin, VkSubpassContents contents) Line 864
VulkanCommandBuffer::beginRenderPass(const RenderPassBegin & renderPassBegin, VkSubpassContents contents) Line 859
VkPPRenderState::RenderScreenQuad(VkPPRenderPassSetup * passSetup, VulkanDescriptorSet * descriptorSet, VulkanFramebuffer * framebuffer, int framebufferWidth, int framebufferHeight, int x, int y, int width, int height, const void * pushConstants, unsigned int pushConstantsSize, bool stencilTest) Line 544
VkPPRenderState::Draw() Line 509
PPCameraExposure::Render(PPRenderState * renderstate, int sceneWidth, int sceneHeight) Line 453
VkPostprocess::PostProcessScene(int fixedcm, const std::function<void __cdecl(void)> & afterBloomDrawEndScene2D) Line 50
VulkanFrameBuffer::PostProcessScene(int fixedcm, const std::function<void __cdecl(void)> & afterBloomDrawEndScene2D) Line 602
VulkanFrameBuffer::RenderViewpoint(FRenderViewpoint & mainvp, AActor * camera, IntRect * bounds, float fov, float ratio, float fovratio, bool mainview, bool toscreen) Line 492
VulkanFrameBuffer::WriteSavePic(player_t * player, FileWriter * file, int width, int height) Line 344
PutSavePic::__l7::<lambda>() Line 2165

It doesn't happen with validation layers enabled though.

[dpJudas]

I pushed another commit that may be the source to that BeginRenderPass crash.

[MasterBeavis]

one build failed
https://ci.appveyor.com/project/coelcke ... 14f0aq8aic

the issue is fixed after trying the studio 2015 one
https://ci.appveyor.com/project/coelcke ... 120fug18ba

[_mental_]

Fixed for me as well.