[g3.8pre-757-g0ed847b51]Dialog Pagenames as String fails

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
User avatar
Zergeant
Posts: 107
Joined: Tue Aug 31, 2010 7:19 am
Location: Sweden

[g3.8pre-757-g0ed847b51]Dialog Pagenames as String fails

Post by Zergeant »

Using the pagename property as a string instead of number, it doesn't go to the next page properly, I've double-checked the names and it will either spit out an invalid node xx error in the console or it will go to a completely unrelated page. Number of pages have been cut down in order to debug easier.

Code: Select all

conversation
{
	// A hotheaded boy with a story to tell.
	actor = "Archvile";
	
	// Intro
	page
	{
		name = "Hothead";
		pagename = "Hello";
		dialog = "I got a burning feelin'!";
		choice
		{
			text = "Really now?";
			nextpage = "MyFeels";
		}
	}
	
	// Second page
	page
	{
		name = "Hothead";
		pagename = "MyFeels";
		dialog = "Yeah... My fiancee just left me...";
		choice
		{
			text = "Sorry to hear...";
			nextpage = "Japed";
		}
	}
	
	// Third page
	page
	{
		name = "Hothead";
		pagename = "Japed";
		dialog = "That's okay, we weren't doing too hot anyway! Har har har!";
		choice
		{
			text = "I ought to shoot you for that pun...";
			nextpage = "Hello";
		}
	}
}
This will result in an invalid node 11 not found error, running on g3.8pre-757-g0ed847b51.
Attachments
TutorialDialogue.wad
Demo map
(10.08 KiB) Downloaded 33 times
User avatar
Rachael
Posts: 13530
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: [g3.8pre-757-g0ed847b51]Dialog Pagenames as String fails

Post by Rachael »

Huh. As far as I can recall, no one poked me about this, and this is a little important. I don't have time to look into it today - but I am bumping this as a reminder to myself to look into this.
User avatar
Nash
 
 
Posts: 17433
Joined: Mon Oct 27, 2003 12:07 am
Location: Kuala Lumpur, Malaysia
Contact:

Re: [g3.8pre-757-g0ed847b51]Dialog Pagenames as String fails

Post by Nash »

Sorry, I thought you'd already seen it. :) Yeah I was about to ask you about this issue recently but figured you had other things going on.
User avatar
Rachael
Posts: 13530
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: [g3.8pre-757-g0ed847b51]Dialog Pagenames as String fails

Post by Rachael »

The point of failure seems to be here:

https://github.com/coelckers/gzdoom/blo ... f.cpp#L602

But I can't for the life of me figure out what's wrong with this statement. I sent Graf a PM to see if he has any idea but he might be busy. If anyone else has any clue what's happening here, I'm all ears.

This uses a hash table TArray.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: [g3.8pre-757-g0ed847b51]Dialog Pagenames as String fails

Post by _mental_ »

There is nothing wrong with that line. The problem is in indexing of pages by names.
Numerical index refers the next page relatively to the root of conversation. Names are converted to absolute indices counted from zero.
User avatar
Rachael
Posts: 13530
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: [g3.8pre-757-g0ed847b51]Dialog Pagenames as String fails

Post by Rachael »

Ugh. :|

Okay, I see.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: [g3.8pre-757-g0ed847b51]Dialog Pagenames as String fails

Post by _mental_ »

Fixed in a54bc61.
User avatar
Rachael
Posts: 13530
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: [g3.8pre-757-g0ed847b51]Dialog Pagenames as String fails

Post by Rachael »

Thank you, _mental_. :)
Post Reply

Return to “Closed Bugs [GZDoom]”