[4.0.0] Where's the "Ouch" face?

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
User avatar
A_D_M_E_R_A_L
Posts: 284
Joined: Sun Apr 16, 2017 2:55 am
Preferred Pronouns: He/Him

[4.0.0] Where's the "Ouch" face?

Post by A_D_M_E_R_A_L »

The "Ouch" face doesn't work as it should in GZD. Mod used in this screenshot: Pandemonia
https://cdn.discordapp.com/attachments/ ... m_4246.png
User avatar
Enjay
 
 
Posts: 26516
Joined: Tue Jul 15, 2003 4:58 pm
Location: Scotland
Contact:

Re: [4.0.0] Where's the "Ouch" face?

Post by Enjay »

Seems to be. Without mods loaded and simply firing the rocket launcher at the floor in front of me, I was able to reliably get the ouch face in g3.3pre39-g2f45218 (which I happen to have installed for no really good reason) but in 4.0.0 and today's git build, I was not able to get the ouch face despite trying repeatedly. All I ever got was the pain grimace or straight to the dead face.
User avatar
Player701
 
 
Posts: 1636
Joined: Wed May 13, 2009 3:15 am
Graphics Processor: nVidia with Vulkan support
Contact:

Re: [4.0.0] Where's the "Ouch" face?

Post by Player701 »

Confirmed. Bisecting indicates it probably started to happen in this commit... yeah, that one again. Some adjacent commits could not be tested because they crash as soon as the game starts, but they don't seem to contain any changes that may have triggerred this bug. On the other hand, the commit I linked to has this.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [4.0.0] Where's the "Ouch" face?

Post by Graf Zahl »

The ouch face and event handlers do not share any code, though, so it's more likely one of the adjacent commits.
Of course, the event handler code made quite a mess of all code it originally touched, so who knows...
User avatar
Player701
 
 
Posts: 1636
Joined: Wed May 13, 2009 3:15 am
Graphics Processor: nVidia with Vulkan support
Contact:

Re: [4.0.0] Where's the "Ouch" face?

Post by Player701 »

The call to StatusBar->CallTick has been moved to another place within the P_Ticker function since that commit (see second link), and that could be the cause of the bug. I haven't looked deeper into the whole call chain there, though. What I can say for sure is that the value of the mugshot's FaceHealth field and the player's health appear to be always synchronized but the ouch face code expects them to be different at times.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: [4.0.0] Where's the "Ouch" face?

Post by _mental_ »

Indeed, the problem is the value of ouch is always false. This is the consequence of the mentioned change, i.e. the move of StatusBar->CallTick() line.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [4.0.0] Where's the "Ouch" face?

Post by Graf Zahl »

That piece of code is a textbook example of depending on side effects from other places. The main problem being that the old order of things was wrong - the status bar never got the full state of the frame to be displayed. Unfortunately the mug shot code is an area where my knowledge is limited because I only use the alternative HUD myself which doesn't have it.

So what piece of code needs to be moved where? I'm not really sure.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [4.0.0] Where's the "Ouch" face?

Post by Graf Zahl »

I changed the setup but I'm afraid this has to be tested by someone else, I'm not sure it's 100% correct.
User avatar
Player701
 
 
Posts: 1636
Joined: Wed May 13, 2009 3:15 am
Graphics Processor: nVidia with Vulkan support
Contact:

Re: [4.0.0] Where's the "Ouch" face?

Post by Player701 »

I'm not seeing any new commits, and for me the bug is still present...
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [4.0.0] Where's the "Ouch" face?

Post by Graf Zahl »

Damn, the change got lost in a branch switch, it seems.
User avatar
Player701
 
 
Posts: 1636
Joined: Wed May 13, 2009 3:15 am
Graphics Processor: nVidia with Vulkan support
Contact:

Re: [4.0.0] Where's the "Ouch" face?

Post by Player701 »

Just wanted to confirm that this bug is still present as of GZDoom 4.1.0.
User avatar
A_D_M_E_R_A_L
Posts: 284
Joined: Sun Apr 16, 2017 2:55 am
Preferred Pronouns: He/Him

Re: [4.0.0] Where's the "Ouch" face?

Post by A_D_M_E_R_A_L »

Still present in 4.1.1
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [4.0.0] Where's the "Ouch" face?

Post by Graf Zahl »

Obviously, condidering nothing has been done about it yet.
User avatar
Player701
 
 
Posts: 1636
Joined: Wed May 13, 2009 3:15 am
Graphics Processor: nVidia with Vulkan support
Contact:

Re: [4.0.0] Where's the "Ouch" face?

Post by Player701 »

I'm terribly sorry for the bump, but is there any chance this could be fixed in the next release? I really miss the good old ouch face... :(
User avatar
Rachael
Posts: 13530
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: [4.0.0] Where's the "Ouch" face?

Post by Rachael »

If you have any ideas how to fix it and you think you can submit a PR within the next few hours, sure. It can be included.
Post Reply

Return to “Closed Bugs [GZDoom]”