Ambient Occlusion gets Amplified with MSAA on and portals.

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
XxMiltenXx
Posts: 219
Joined: Wed Jan 08, 2014 8:40 am
Graphics Processor: nVidia with Vulkan support
Location: Germany

Ambient Occlusion gets Amplified with MSAA on and portals.

Post by XxMiltenXx »

As it says in the title. In some instances, enabling (and raising) the MSAA setting amplifies the Ambient Occlusion Effect (set on "High" in the test case), Portals with AO set to 4. I observed this in "Winter's Fury", however, in Doom 2 MAP01, this doesn't happen. Only Vulkan is affected. OpenGL works fine.

MSAA Off:
MSAA_Off.png
MSAA 32x:
MSAA_32x.png
Winter's Fury Download: https://www.doomworld.com/forum/topic/6 ... ters-fury/

EDIT: This seems to be a portal bug. Winter's Fury uses portals. If you raise the number of "Portals" with AO, it'll get amplified. Depending on the position, the ambient occlusion effect might even vanish completely (if you go to the left of the building for example).
dpJudas
 
 
Posts: 3037
Joined: Sat May 28, 2016 1:01 pm

Re: Ambient Occlusion gets Amplified with MSAA on and portal

Post by dpJudas »

Pushed a fix for this.
XxMiltenXx
Posts: 219
Joined: Wed Jan 08, 2014 8:40 am
Graphics Processor: nVidia with Vulkan support
Location: Germany

Re: Ambient Occlusion gets Amplified with MSAA on and portal

Post by XxMiltenXx »

Only partially resolved. When MSAA is changed the ambient occlusion effect won't get amplified anymore.

However, having portals and raising "Portals with AO" still amplifies the Ambient Occlusion Effect.
dpJudas
 
 
Posts: 3037
Joined: Sat May 28, 2016 1:01 pm

Re: Ambient Occlusion gets Amplified with MSAA on and portal

Post by dpJudas »

Do you have a position I can use with the warp command to see this better? I'm not sure I'm standing the right place.
User avatar
Nash
 
 
Posts: 17434
Joined: Mon Oct 27, 2003 12:07 am
Location: Kuala Lumpur, Malaysia
Contact:

Re: Ambient Occlusion gets Amplified with MSAA on and portal

Post by Nash »



It's not limited to MSAA only. I get this effect with FXAA too. Easy to reproduce in Kinsie's test map http://thekinsie.com/crap/kinstest.zip ("map test" in console) from the position in the picture. Walk forward from here, until the mirror is visible from the room to the left.
XxMiltenXx
Posts: 219
Joined: Wed Jan 08, 2014 8:40 am
Graphics Processor: nVidia with Vulkan support
Location: Germany

Re: Ambient Occlusion gets Amplified with MSAA on and portal

Post by XxMiltenXx »

Just at the beginning starting position of the first map I can see that effect already. Just look at the grass, the frozen lake to the left or the big entrance building, or the ledge of the ceiling of the cave you start in:

Ambient Occlusion High, Portals with AO = 2
Screenshot_Doom_20190506_013817.png

Ambient Occlusion High, Portals with AO = 4
Screenshot_Doom_20190506_013828.png
The grass is much darker in the latter and the other differences mentioned above.

@Nash: I do not have this issue with FXAA, at least not with the latest version.
dpJudas
 
 
Posts: 3037
Joined: Sat May 28, 2016 1:01 pm

Re: Ambient Occlusion gets Amplified with MSAA on and portal

Post by dpJudas »

Fixed the portal bug.
User avatar
Darkcrafter
Posts: 562
Joined: Sat Sep 23, 2017 8:42 am
Operating System Version (Optional): Windows 10
Graphics Processor: nVidia with Vulkan support

Re: Ambient Occlusion gets Amplified with MSAA on and portal

Post by Darkcrafter »

God I absolutely hate fake occlussion, they put it everywhere in modern games! I always let it off in the settings if it's possible. It even adds up to a player's hud weapons as it gets closer to a ground or wall, so there appears a dark "glowing" around. And it doesn't happen in real life because it heavily depends on lighting. Wisdom 3d artists from vray and mental ray schools know a real name for such a cheap technique - dirt shader.
User avatar
Rachael
Posts: 13531
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Ambient Occlusion gets Amplified with MSAA on and portal

Post by Rachael »

This isn't really relevant for a development ticket thread. :|

You really should've made a new thread in off-topic for such a comment.
Post Reply

Return to “Closed Bugs [GZDoom]”