Check for Monster Armor

[Grey-Wolf]

Hello!

I have some free time today, so I'm I'm back at scripting.
Currently, I'm trying to make monsters more diverse by giving them armor based on their features.
I'm using a pre-made script that was included in Brutal Doom to show monster's health when you hover the crosshair over them.
This is the one:

---

Code: Select all

#library "EnemyScouterThing"
#include "zcommon.acs"

str enemyname;
int enemyhealthmax;
int enemyhealth;
int monstercount;
int enemyarmor;
int enemyarmorPERCENT;

script "EnemyScouterThing" ENTER
{
	if	(GetCvar( "bd_disablescanner") == 1) { terminate;}
	monstercount = GetLevelInfo (LEVELINFO_KILLED_MONSTERS);
	
	while(TRUE)
	{
	
		//NOTE:	PickActor requires careful handling. See the zdoom wiki about that!
		//		Actor's old TID needs to be saved, assigned a new TID, then restored back to old TID to keep things operational.
		int old_tid = PickActor(0, GetActorAngle(0), GetActorPitch(0), 2048.0, 0, MF_SHOOTABLE | !MF_CORPSE, ML_BLOCKEVERYTHING | ML_BLOCKHITSCAN, PICKAF_RETURNTID);
		
		int new_tid = UniqueTID();
	
		if(PickActor(0, GetActorAngle(0), GetActorPitch(0), 2048.0, new_tid, MF_SHOOTABLE | !MF_CORPSE, ML_BLOCKEVERYTHING | ML_BLOCKHITSCAN, PICKAF_FORCETID))
		{	
		
			//GET ACTOR INFO
			enemyname = GetActorProperty(new_tid, APROP_NameTag);			//name
			enemyhealthmax = GetActorProperty(new_tid, APROP_SpawnHealth);	//max hp
			enemyhealth = GetActorProperty(new_tid, APROP_HEALTH); 			//current hp
			

			//ACTOR HEALTH DISPLAY
		if(GetActorProperty(new_tid, APROP_Speed) > 0)
		{
			if (enemyhealth >= 1)
			{
				//ACTOR NAME DISPLAY
				HudMessage(	s:"", 
						s:enemyname;
						HUDMSG_FADEOUT, 112223, CR_DARKRED, 0.5, 0.02, 0.6, 0.2);
			
				int pc = enemyhealth * 100 / enemyhealthmax;
				
				if(pc>=75)
				{
					HudMessage(	s:"\n",
					d:enemyhealth,
					s:"/",
					d:enemyhealthmax;
					HUDMSG_FADEOUT, 112224, CR_TAN, 0.5, 0.02, 0.6, 0.2);	
				}
				else if(pc>=50)
				{
					HudMessage(	s:"\n",
					d:enemyhealth,
					s:"/",
					d:enemyhealthmax;
					HUDMSG_FADEOUT, 112224, CR_GOLD, 0.5, 0.02, 0.6, 0.2);	
				}
				else if(pc>=25)
				{
					HudMessage(	s:"\n",
					d:enemyhealth,
					s:"/",
					d:enemyhealthmax;
					HUDMSG_FADEOUT, 112224, CR_ORANGE, 0.5, 0.02, 0.6, 0.2);	
				}
				else if(pc>=0)
				{
					HudMessage(	s:"\n",
					d:enemyhealth,
					s:"/",
					d:enemyhealthmax;
					HUDMSG_FADEOUT, 112224, CR_RED, 0.5, 0.02, 0.6, 0.2);	
				}
				
				//ACTOR FRIENDLY INDICATOR	
				if(GetActorProperty(new_tid, APROP_Friendly) == TRUE)
				{
					HudMessage(	s:"\n\n-Friendly-";
								HUDMSG_FADEOUT, 112225, CR_GREEN, 0.5, 0.02, 0.6, 0.2);
				}
			} 
		}	

Now, I want to also show their armor, but as you surely know, GetArmorInfo only works on players. I did some other tests, but nothing worked. Do any of you have some ideas to share?

[TDRR]

Um, i'm pretty sure enemies can't carry armor.

[Grey-Wolf]

They can. I gave it to them with a_giveinventory in their spawn state, and it works as intended.

[Blue Shadow]

Do any of you have some ideas to share?

Yeah, ZScript. Create a function that would allow you to get the information you need about the armor. After you do that, you can use [wiki]ScriptCall[/wiki] to use that function in ACS (if you need to use it in ACS that is).


Edit: If all you want to know is how much armor points the actor has, then you don't need ZScript. You can just use ACS's CheckInventory() while passing "BasicArmor" as the item to check for.

[Grey-Wolf]

Code: Select all

//GET ACTOR INFO
			enemyname = GetActorProperty(new_tid, APROP_NameTag);			//name
			enemyhealthmax = GetActorProperty(new_tid, APROP_SpawnHealth);	//max hp
			enemyhealth = GetActorProperty(new_tid, APROP_HEALTH); 			//current hp
         enemyarmor = Checkinventory("BasicArmor");
			

			//ACTOR HEALTH DISPLAY
		if(GetActorProperty(new_tid, APROP_Speed) > 0)
		{
			if (enemyhealth >= 1)
			{
				//ACTOR NAME DISPLAY
				HudMessage(	s:"", 
						s:enemyname;
						HUDMSG_FADEOUT, 112223, CR_DARKRED, 0.5, 0.02, 0.6, 0.2);
          HudMessage(	s:"\n \n", 
						s:enemyarmor;
						HUDMSG_FADEOUT, 112226, CR_DARKGREY, 0.5, 0.02, 0.6, 0.2);

This doesn't seem to work... instead, it shows me a totally different string, "bars raised." Pretty unsure what could be causing this.

[Blue Shadow]

Change s:enemyarmor to d:enemyarmor in the HudMessage call.

[Grey-Wolf]

Change s:enemyarmor to d:enemyarmor in the HudMessage call.

Of course, I'm such an idiot -_-"
But still, something's not right. When I spawn an enemy wearing armor and aim at them, I just see a "0" under their health. Then, after some seconds, the zero turns into a "200", no matter the kind of armor they're wearing.

To make things clearer:
This is the updated code for the hud script:

---

Code: Select all

#library "EnemyScouterThing"
#include "zcommon.acs"

str enemyname;
int enemyhealthmax;
int enemyhealth;
int monstercount;
int enemyarmor;
int enemyarmorPERCENT;

script "EnemyScouterThing" ENTER
{
	if	(GetCvar( "bd_disablescanner") == 1) { terminate;}
	monstercount = GetLevelInfo (LEVELINFO_KILLED_MONSTERS);
	
	while(TRUE)
	{
	
		//NOTE:	PickActor requires careful handling. See the zdoom wiki about that!
		//		Actor's old TID needs to be saved, assigned a new TID, then restored back to old TID to keep things operational.
		int old_tid = PickActor(0, GetActorAngle(0), GetActorPitch(0), 2048.0, 0, MF_SHOOTABLE | !MF_CORPSE, ML_BLOCKEVERYTHING | ML_BLOCKHITSCAN, PICKAF_RETURNTID);
		
		int new_tid = UniqueTID();
	
		if(PickActor(0, GetActorAngle(0), GetActorPitch(0), 2048.0, new_tid, MF_SHOOTABLE | !MF_CORPSE, ML_BLOCKEVERYTHING | ML_BLOCKHITSCAN, PICKAF_FORCETID))
		{	
		
			//GET ACTOR INFO
			enemyname = GetActorProperty(new_tid, APROP_NameTag);			//name
			enemyhealthmax = GetActorProperty(new_tid, APROP_SpawnHealth);	//max hp
			enemyhealth = GetActorProperty(new_tid, APROP_HEALTH); 			//current hp
			enemyarmor = Checkinventory("BasicArmor");
			

			//ACTOR HEALTH DISPLAY
		if(GetActorProperty(new_tid, APROP_Speed) > 0)
		{
			if (enemyhealth >= 1)
			{
				//ACTOR NAME DISPLAY
				HudMessage(	s:"", 
						s:enemyname;
						HUDMSG_FADEOUT, 112223, CR_DARKRED, 0.5, 0.02, 0.6, 0.2);
				HudMessage(	s:"\n \n", 
						d:enemyarmor;
						HUDMSG_FADEOUT, 112226, CR_DARKGREY, 0.5, 0.02, 0.6, 0.2);
			
				int pc = enemyhealth * 100 / enemyhealthmax;
				
				if(pc>=75)
				{
					HudMessage(	s:"\n",
					d:enemyhealth,
					s:"/",
					d:enemyhealthmax;
					HUDMSG_FADEOUT, 112224, CR_TAN, 0.5, 0.02, 0.6, 0.2);	
				}
				else if(pc>=50)
				{
					HudMessage(	s:"\n",
					d:enemyhealth,
					s:"/",
					d:enemyhealthmax;
					HUDMSG_FADEOUT, 112224, CR_GOLD, 0.5, 0.02, 0.6, 0.2);	
				}
				else if(pc>=25)
				{
					HudMessage(	s:"\n",
					d:enemyhealth,
					s:"/",
					d:enemyhealthmax;
					HUDMSG_FADEOUT, 112224, CR_ORANGE, 0.5, 0.02, 0.6, 0.2);	
				}
				else if(pc>=0)
				{
					HudMessage(	s:"\n",
					d:enemyhealth,
					s:"/",
					d:enemyhealthmax;
					HUDMSG_FADEOUT, 112224, CR_RED, 0.5, 0.02, 0.6, 0.2);	
				}
				
				//ACTOR FRIENDLY INDICATOR	
				if(GetActorProperty(new_tid, APROP_Friendly) == TRUE)
				{
					HudMessage(	s:"\n\n-Friendly-";
								HUDMSG_FADEOUT, 112225, CR_GREEN, 0.5, 0.02, 0.6, 0.2);
				}
			} 
		}	

This is the Custom armor I'm using for the monster:

---

Code: Select all

Actor 100ArmorMed : BasicArmorPickup
{
	Game Doom
	Scale 0.3
	SpawnID 67
	Radius 20
	Height 16
	Inventory.Pickupmessage "Your skin has become hard as iron!"
	Inventory.Icon "ARM1B0"
	Armor.SavePercent 99.99
	Armor.SaveAmount 600
    Inventory.PickupSound "ARMOR"
	States
	{
	Spawn:
		ARM1 A 10
		loop

	}
}

And this is the spawn state of said monster:

---

Code: Select all

 { 
   Spawn: 
	   TNT1 A 1
	   TNT1 A 0 A_GiveInventory("100ArmorMed")
       TERM AB 10 A_Look 
       Loop 

Note that I get the same results with other monster and other armor types, so I think the problem is elsewhere.

[Blue Shadow]

Okay, switch to using [wiki]CheckActorInventory[/wiki]. It allows you to pass a [wiki]TID[/wiki]:

Code: Select all

enemyarmor = CheckActorInventory(new_tid, "BasicArmor");