[Fixed] [4f0850b09] This map crashes GZDoom everytime

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

[4f0850b09] This map crashes GZDoom everytime

Postby Kizoky » Wed Feb 06, 2019 10:44 am

User avatar
Kizoky
I smell like gravity
 
Joined: 14 Nov 2011
Location: Around weirdos, I'm the biggest weirdo among them
Discord: Kizoky#0375
Operating System: Windows 10/8.1/8 64-bit
Graphics Processor: nVidia with Vulkan support

Re: [4f0850b09] This map crashes GZDoom everytime

Postby Rachael » Wed Feb 06, 2019 11:06 am

This crash happens because "origin" is nullptr in function *COPY_AAPTR in actorptrselect.cpp. (line ~65 or so)

Putting this at the beginning of the function fixes the crash, but I am not sure this is the correct way to handle it, so I am posting it here instead:
Code: Select allExpand view
   if (!origin)
      return nullptr;
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: [4f0850b09] This map crashes GZDoom everytime

Postby Graf Zahl » Thu Feb 07, 2019 9:43 am

Fixed. And just like I suspected, adding that check would have broken the entire thing.
The problem here was that when being called from ACS, the origin can be null - but still needs to be able to resolve the player constants to the actual player.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Closed Bugs

Who is online

Users browsing this forum: Bing [Bot] and 0 guests