TUTNT ceiling flat issue

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
Blue Shadow
Posts: 4949
Joined: Sun Nov 14, 2010 12:59 am

TUTNT ceiling flat issue

Post by Blue Shadow »

Tested with: 3.7.2 (64-bit)
Test material: The Ultimate Torment & Torture
Spoiler: Start-up log
See those blue ceiling flats. They obviously shouldn't be visible.

[imgur]https://i.imgur.com/LrW7HfN[/imgur]
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: TUTNT ceiling flat issue

Post by Graf Zahl »

Sigh... Remove some broken hack support and you can be sure to find maps that are made badly enough to require it...
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: TUTNT ceiling flat issue

Post by Graf Zahl »

This was fixed a few days ago.
User avatar
Caligari87
Admin
Posts: 6174
Joined: Thu Feb 26, 2004 3:02 pm
Preferred Pronouns: He/Him
Contact:

Re: TUTNT ceiling flat issue

Post by Caligari87 »

I'm just curious, what was the hack in this case and why is it a bad construction?

8-)
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: TUTNT ceiling flat issue

Post by Graf Zahl »

This was caused by a oversight in ZDoom's original stacked sector code. When building the visplanes it checked all the texture properties of two sectors and if identical merged them. But what it forgot was to check if a sector even had a portal! Remember, this stuff way quickly slapped together and even more quickly abandoned when it became clear that it wasn't going to work out that well.

As a result any sector that lies completely within a portal sector but has no portal itself but the same plane properties would be automatically merged into the portal. The GL renderer has no concept of visplanes so wouldn't do such a thing. I had some hacky workaround for this in the renderer but had to ultimately disable it for compatibility issues. I had known of only one map needing this (KDIZD's Z1M1, which I fixed in the map before the release) so I didn't consider this a needed fix. But this map ran into the same issue so I had to bring back that hacky fix in a less problematic reincarnation.
User avatar
Caligari87
Admin
Posts: 6174
Joined: Thu Feb 26, 2004 3:02 pm
Preferred Pronouns: He/Him
Contact:

Re: TUTNT ceiling flat issue

Post by Caligari87 »

I see, thanks for explaining!

8-)
Post Reply

Return to “Closed Bugs [GZDoom]”