[Fixed] A_FireProjectile does not handle FPF_NOAUTOAIM

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

A_FireProjectile does not handle FPF_NOAUTOAIM

Postby Marisa Kirisame » Fri Jan 25, 2019 6:47 pm

This was encountered by someone in a certain place who refused to report the bug.

The bug was introduced after this function was scriptified. After some digging I can see it's because the call to SpawnPlayerMissile was not adapted to the arguments the zscript version of it takes. Just removing the "NULL" on line 115 of stateprovider.txt should do the job.
User avatar
Marisa Kirisame
ZScript Magician
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: Marisa Kirisame#4689
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
Graphics Processor: nVidia with Vulkan support

Re: A_FireProjectile does not handle FPF_NOAUTOAIM

Postby Turret49 » Sat Jan 26, 2019 1:15 am

I know it's a deprecated function but A_FireCustomMissile has this problem as well.
Turret49
 
Joined: 29 Aug 2015

Re: A_FireProjectile does not handle FPF_NOAUTOAIM

Postby Kinsie » Sat Jan 26, 2019 1:24 am

Marisa Kirisame wrote:This was encountered by someone in a certain place who refused to report the bug.
It's a pity that I keep seeing stuff like this happening for one reason or another. I've had to nag people from a certain other place into reporting stuff a non-zero amount of times, and it's always draining and frustrating.

I guess some people are just looking for an excuse to be and stay upset? v :| v
User avatar
Kinsie
A Concept Utterly Obsolete
 
Joined: 22 Oct 2004
Location: MAP33
Discord: Find Me...
Twitch ID: thekinsie

Re: A_FireProjectile does not handle FPF_NOAUTOAIM

Postby Graf Zahl » Sat Jan 26, 2019 2:46 am

There is no NULL on line 115 in stateprovider.txt.

If you report bugs this way you really do not help. Either post a link to the problem code that actually shows it (or paste the code into code tags) or make a PR. Now I have to wait for feedback to make sure I fix the right thing. :(
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: A_FireProjectile does not handle FPF_NOAUTOAIM

Postby Marisa Kirisame » Sat Jan 26, 2019 8:40 am

Oh oops, I mean 220. (I have no idea where I got the 115 from now)
User avatar
Marisa Kirisame
ZScript Magician
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: Marisa Kirisame#4689
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
Graphics Processor: nVidia with Vulkan support

Re: A_FireProjectile does not handle FPF_NOAUTOAIM

Postby Graf Zahl » Sat Feb 09, 2019 3:25 am

fixed.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Closed Bugs

Who is online

Users browsing this forum: Google [Bot] and 0 guests