Still happens on cb4548a.
1. Try to run this commit of HD.
2. Read the line number given for "Self pointer used in ambiguous context; VM execution may abort!"
Expected: Line 675
Actual: Line 663
Setting vm_jit in the command line has no effect on this output.
First noticed on Windows build but replicated on own Debian compile.
(Not sure if Windows build was offsetting the line # in the same way)
[3.7.1] VM abort gives wrong line
Moderator: GZDoom Developers
Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Re: [3.7.1] VM abort gives wrong line
The discrepancy is caused by this multi-line thing.
I was surprised that it's correct syntax at all. I thought every line should be wrapped with double quotes like in C/C++.
I was surprised that it's correct syntax at all. I thought every line should be wrapped with double quotes like in C/C++.
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49056
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: [3.7.1] VM abort gives wrong line
I thought so, too. And obviously the parser isn't prepared for that kind of token.
Re: [3.7.1] VM abort gives wrong line
Curiously enough, it works like a raw string literal. Also, we can create kinda multi-line comments inside functions like this as long as it doesn't include double quote.
Unfortunately, it's treated as a single line screwing error/warning reporting. Outside of this issue, it's OK to keep it as is in my opinion.
The topic's title is a bit misleading because this has nothing to do with a runtime exception handling.
Code: Select all
// ... code ...
"
cool
multi-line
comment
";
// ... code ...
The topic's title is a bit misleading because this has nothing to do with a runtime exception handling.
Re: [3.7.1] VM abort gives wrong line
In order to be sure there will be no objections, I made this PR with the fix.
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49056
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: [3.7.1] VM abort gives wrong line
Why should I object?