[Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
User avatar
YukesVonFaust
Posts: 1342
Joined: Mon Feb 09, 2015 9:00 am
Location: in an undisclosed location that is the philippines

[Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Post by YukesVonFaust »

In the newest GZDoom and its devbuilds, the MSX/MSX2 KSS files no longer work and/or play anymore. it plays/works fine in 2.2.0, 3.2.4, and older builds, but not in 3.6.0, 3.7.1, and the latest devbuilds.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Post by Graf Zahl »

This sounds like a problem with the new GME version. So short of reverting this update I doubt something can be done.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Post by _mental_ »

GME was updated after 3.6 while according to the OP this version is affected as well.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Post by Graf Zahl »

Then I have no idea. I have never touched this code.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Post by _mental_ »

I downloaded a few KSS files and they are all silent in 2.2.0 and 3.2.4 both. Did it ever work?
User avatar
YukesVonFaust
Posts: 1342
Joined: Mon Feb 09, 2015 9:00 am
Location: in an undisclosed location that is the philippines

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Post by YukesVonFaust »

_mental_ wrote:I downloaded a few KSS files and they are all silent in 2.2.0 and 3.2.4 both. Did it ever work?
try downloading the metal gear 2 solid snake kss file somewhere, and put :153 at the end, no spaces.

see if it works.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Post by _mental_ »

I see, my problem was in missing track numbers.

Well, this is GME update indeed. It works in 3.6 by the way.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Post by _mental_ »

This can be fixed by reverted Kss_Cpu.cpp to previous version and fixing type definitions to make it compile.
Let me if you want to have this change instead of reverting a whole update.
User avatar
YukesVonFaust
Posts: 1342
Joined: Mon Feb 09, 2015 9:00 am
Location: in an undisclosed location that is the philippines

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Post by YukesVonFaust »

_mental_ wrote:This can be fixed by reverted Kss_Cpu.cpp to previous version and fixing type definitions to make it compile.
Let me if you want to have this change instead of reverting a whole update.
yes, this change is enough.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Post by _mental_ »

YukesVonFaust wrote:
_mental_ wrote:This can be fixed by reverted Kss_Cpu.cpp to previous version and fixing type definitions to make it compile.
Let me if you want to have this change instead of reverting a whole update.
yes, this change is enough.
My message was addressed to Graf ;)
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49056
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Post by Graf Zahl »

Considering the regressions the update brought I'm not sure if it shouldn't be reverted again.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: [Sound] MSX/MSX2 .KSS files no longer work in 3.7.1

Post by _mental_ »

Fixed in df6669b.
Post Reply

Return to “Closed Bugs [GZDoom]”