Hide "invalid sound position/velocity" messages
Moderator: GZDoom Developers
-
-
- Posts: 374
- Joined: Mon Jun 27, 2016 7:26 pm
- Preferred Pronouns: He/Him
- Graphics Processor: nVidia with Vulkan support
- Contact:
Re: Hide "invalid sound position/velocity" messages
For some reason, I get invalid sound position/velocity messages on TNT: Revilution MAP16 after a while, even if I load a mod that removes all the monsters.
- Major Cooke
- Posts: 8175
- Joined: Sun Jan 28, 2007 3:55 pm
- Preferred Pronouns: He/Him
- Location: QZDoom Maintenance Team
Re: Hide "invalid sound position/velocity" messages
It would be greatly appreciated if these could be hidden or at least have a way to turn them off on the clientside.. I sometimes gain these when, in D4D, monsters are blasted by the BFG such as the Lost Soul.
It gets very spammy.
In my case it's only happening when they are simply launched ridiculous speeds because the dying actor gains +NOINTERACTION and uses velocity to fling a 'fake' of itself. Sure I could just call A_StopSound to shut it up which I probably will if this doesn't go away.
It gets very spammy.
In my case it's only happening when they are simply launched ridiculous speeds because the dying actor gains +NOINTERACTION and uses velocity to fling a 'fake' of itself. Sure I could just call A_StopSound to shut it up which I probably will if this doesn't go away.
Re: Hide "invalid sound position/velocity" messages
I agree to make it optional, like developer CVAR should be set to at least one to display them.
Although, it's only about messages as those actors still won't emit any sound.
Although, it's only about messages as those actors still won't emit any sound.
- Major Cooke
- Posts: 8175
- Joined: Sun Jan 28, 2007 3:55 pm
- Preferred Pronouns: He/Him
- Location: QZDoom Maintenance Team
Re: Hide "invalid sound position/velocity" messages
That's fine by me.
- Major Cooke
- Posts: 8175
- Joined: Sun Jan 28, 2007 3:55 pm
- Preferred Pronouns: He/Him
- Location: QZDoom Maintenance Team
Re: Hide "invalid sound position/velocity" messages
Admittedly, for once, I'm glad it's on.
Because getting NaN for positions is not right at all. I'm making a bug report about it as soon as I get more info.
Because getting NaN for positions is not right at all. I'm making a bug report about it as soon as I get more info.
Re: Hide "invalid sound position/velocity" messages
If I knew that this warning will cause such attention, I would add reporting for invalid values only and keep out-of-bounds position/velocity as is.
- Player701
-
- Posts: 1640
- Joined: Wed May 13, 2009 3:15 am
- Graphics Processor: nVidia with Vulkan support
- Contact:
Re: Hide "invalid sound position/velocity" messages
Eh, I'm not sure if it's worth making a bug report for this because PrBoom-Plus seems to work the same way, but I've found a map which makes GZDoom produce a lot of "invalid sound position" messages after pressing a certain switch. This happens on Hadephobia MAP19. To reproduce, use the following command-line parameters:
Turn around and press the switch. In a few minutes, the "invalid sound position" message spam will start. It appears that the floor of sector 195, which is triggered to lower when the switch is pressed, doesn't stop where it has to and continues lowering towards negative infinity. Once the floor height passes a certain threshold, it triggers these warnings. I haven't got any crashes from this behavior so far, but this message spam kind of interferes with the gameplay.
Code: Select all
gzdoom.exe -file h_phobia.wad -nomonsters -warp 19 +"warp 1664 784"
Re: Hide "invalid sound position/velocity" messages
FWiW, it took just shy of 4 minutes after pressing the switch for the messages to start spamming, but when they did, it was constant.
Just a little sample, the full log file by the time I quit breaks the forum character limit:
Just a little sample, the full log file by the time I quit breaks the forum character limit:
Code: Select all
Invalid sound position (1984.000000, 2184.000000, -32772.000000)
Invalid sound position (1984.000000, 2184.000000, -32776.000000)
Invalid sound position (1984.000000, 2184.000000, -32780.000000)
Invalid sound position (1984.000000, 2184.000000, -32784.000000)
Invalid sound position (1984.000000, 2184.000000, -32788.000000)
Invalid sound position (1984.000000, 2184.000000, -32792.000000)
Invalid sound position (1984.000000, 2184.000000, -32796.000000)
Invalid sound position (2002.150879, 2184.000000, -32800.000000)
Invalid sound position (2022.977661, 2184.000000, -32804.000000)
Invalid sound position (2043.691284, 2184.000000, -32808.000000)
Invalid sound position (2062.796387, 2184.000000, -32812.000000)
Invalid sound position (2080.443604, 2184.000000, -32816.000000)
Invalid sound position (2096.770020, 2184.000000, -32820.000000)
Invalid sound position (2111.899170, 2184.000000, -32824.000000)
Invalid sound position (2112.000000, 2184.000000, -32828.000000)
Invalid sound position (2112.000000, 2184.000000, -32832.000000)
Invalid sound position (2112.000000, 2184.000000, -32836.000000)
Invalid sound position (2112.000000, 2184.000000, -32840.000000)
Invalid sound position (2112.000000, 2184.000000, -32844.000000)
Invalid sound position (2112.000000, 2184.000000, -32848.000000)
Invalid sound position (2112.000000, 2184.000000, -32852.000000)
Invalid sound position (2112.000000, 2184.000000, -32856.000000)
Invalid sound position (2112.000000, 2184.000000, -32860.000000)
Invalid sound position (2112.000000, 2184.000000, -32864.000000)
Invalid sound position (2112.000000, 2184.000000, -32868.000000)
Invalid sound position (2112.000000, 2184.000000, -32872.000000)
Invalid sound position (2112.000000, 2184.000000, -32876.000000)
Invalid sound position (2112.000000, 2184.000000, -32880.000000)
Invalid sound position (2112.000000, 2184.000000, -32884.000000)
Invalid sound position (2112.000000, 2184.000000, -32888.000000)
Invalid sound position (2112.000000, 2184.000000, -32892.000000)
Invalid sound position (2112.000000, 2184.000000, -32896.000000)
Invalid sound position (2112.000000, 2184.000000, -32900.000000)
Invalid sound position (2112.000000, 2184.000000, -32904.000000)
Invalid sound position (2112.000000, 2184.000000, -32908.000000)
Invalid sound position (2112.000000, 2184.000000, -32912.000000)
Invalid sound position (2112.000000, 2184.000000, -32916.000000)
Invalid sound position (2112.000000, 2184.000000, -32920.000000)
Invalid sound position (2112.000000, 2184.000000, -32924.000000)
Invalid sound position (2112.000000, 2184.000000, -32928.000000)
Invalid sound position (2112.000000, 2184.000000, -32932.000000)
Invalid sound position (2112.000000, 2184.000000, -32936.000000)
Invalid sound position (2112.000000, 2184.000000, -32940.000000)
Invalid sound position (2112.000000, 2184.000000, -32944.000000)
Invalid sound position (2112.000000, 2184.000000, -32948.000000)
Invalid sound position (2112.000000, 2184.000000, -32952.000000)
Invalid sound position (2112.000000, 2184.000000, -32956.000000)
Invalid sound position (2112.000000, 2184.000000, -32960.000000)
Invalid sound position (2112.000000, 2184.000000, -32964.000000)
Invalid sound position (2112.000000, 2184.000000, -32968.000000)
Invalid sound position (2112.000000, 2184.000000, -32972.000000)
Invalid sound position (2112.000000, 2184.000000, -32976.000000)
Invalid sound position (2112.000000, 2184.000000, -32980.000000)
Invalid sound position (2112.000000, 2184.000000, -32984.000000)
Invalid sound position (2112.000000, 2184.000000, -32988.000000)
Invalid sound position (2112.000000, 2184.000000, -32992.000000)
Invalid sound position (2112.000000, 2184.000000, -32996.000000)
Invalid sound position (2112.000000, 2184.000000, -33000.000000)
Invalid sound position (2112.000000, 2184.000000, -33004.000000)
Invalid sound position (2112.000000, 2184.000000, -33008.000000)
Invalid sound position (2112.000000, 2184.000000, -33012.000000)
Invalid sound position (2112.000000, 2184.000000, -33016.000000)
Invalid sound position (2112.000000, 2184.000000, -33020.000000)
Invalid sound position (2112.000000, 2184.000000, -33024.000000)
Invalid sound position (2112.000000, 2184.000000, -33028.000000)
Invalid sound position (2112.000000, 2184.000000, -33032.000000)
Invalid sound position (2112.000000, 2184.000000, -33036.000000)
Invalid sound position (2112.000000, 2184.000000, -33040.000000)
Invalid sound position (2112.000000, 2184.000000, -33044.000000)
Invalid sound position (2112.000000, 2184.000000, -33048.000000)
Invalid sound position (2112.000000, 2184.000000, -33052.000000)
Invalid sound position (2112.000000, 2184.000000, -33056.000000)
Invalid sound position (2112.000000, 2184.000000, -33060.000000)
Re: Hide "invalid sound position/velocity" messages
Graf, are you OK with checking for infinite values only to output this message? I'm really tired of it, but making it optional is equal to making it useless IMHO.
-
- Posts: 384
- Joined: Mon May 09, 2016 1:38 am
- Location: Anywhere but here
- Contact:
Re: Hide "invalid sound position/velocity" messages
Fix your mod then, instead of asking the developers to fix it for you with a bunch of pointless code.
Re: Hide "invalid sound position/velocity" messages
Wouldn't it be better to possibly do a compatibility fix on the offending object so that it cannot fall below Z -32768.00?
- wildweasel
- Posts: 21706
- Joined: Tue Jul 15, 2003 7:33 pm
- Preferred Pronouns: He/Him
- Operating System Version (Optional): A lot of them
- Graphics Processor: Not Listed
- Contact:
Re: Hide "invalid sound position/velocity" messages
"Fix your mod" isn't necessarily a solution when "your mod" is somebody else's mod from years ago that worked fine until recently. (Especially if, in the case of a handful of mods I know, their licenses restrict people from releasing modified/fixed versions.)XLightningStormL wrote:Fix your mod then, instead of asking the developers to fix it for you with a bunch of pointless code.
- Matt
- Posts: 9696
- Joined: Sun Jan 04, 2004 5:37 pm
- Preferred Pronouns: They/Them
- Operating System Version (Optional): Debian Bullseye
- Location: Gotham City SAR, Wyld-Lands of the Lotus People, Dominionist PetroConfederacy of Saudi Canadia
- Contact:
Re: Hide "invalid sound position/velocity" messages
I remember asking a couple months back if a certain troublesome thing could be made to be subject to ZScript versioning and it was considered impossible or at least impractical to the point of impossibility, was it this?
- Chris
- Posts: 2942
- Joined: Thu Jul 17, 2003 12:07 am
- Graphics Processor: ATI/AMD with Vulkan/Metal Support
Re: Hide "invalid sound position/velocity" messages
IIRC, the message was originally added because of errant NaNs being generated in a mod, so at the very least it should be non-finite values._mental_ wrote:Graf, are you OK with checking for infinite values only to output this message? I'm really tired of it, but making it optional is equal to making it useless IMHO.
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49067
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: Hide "invalid sound position/velocity" messages
I think the value range should at least be expanded. But if some truly outlandish numbers get through here they should still be reported. Something like 40000 may just be a quirk with the game physics, but something like, say 1'000'000 normally is a sign of an error.