[Master] VM Abort when shooting a barrel in Harmony

Post by **Rachael** » Mon Jan 07, 2019 1:34 am

Harmony is available here

When shooting any of the "ExplosiveBarrel" types in Harmony, a VM abort is immediately caused. This happens even with +vm_jit 0.

Post by **_mental_** » Mon Jan 07, 2019 8:24 am

The issue was introduced in this commit. It affects 3.7 release too.

Post by **Graf Zahl** » Mon Jan 07, 2019 8:39 am

While the check is correct, it needs to be disabled if a state gets modified by Dehacked.

Post by **_mental_** » Sat Jan 12, 2019 2:53 am

Is it about disabling of this check if the state was modified by Dehacked? Or is it about a whole FState::CheckCallerType() function?

Post by **Graf Zahl** » Sat Jan 12, 2019 3:46 am

The other checks would be crash issues, but that particular one needs to be disable for Dehacked-modified states, because the non-Actor functions that can be set here would otherwise cause an abort. All Dehacked-usable functions should contain enough safety checks to not crash.

Post by **_mental_** » Sat Jan 12, 2019 4:22 am

Fixed in e353201.

ZDoom