[Master] VM Abort when shooting a barrel in Harmony
Moderator: GZDoom Developers
Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
[Master] VM Abort when shooting a barrel in Harmony
Harmony is available here
When shooting any of the "ExplosiveBarrel" types in Harmony, a VM abort is immediately caused. This happens even with +vm_jit 0.
Re: [Master] VM Abort when shooting a barrel in Harmony
The issue was introduced in this commit. It affects 3.7 release too.
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49067
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: [Master] VM Abort when shooting a barrel in Harmony
While the check is correct, it needs to be disabled if a state gets modified by Dehacked.
Re: [Master] VM Abort when shooting a barrel in Harmony
Is it about disabling of this check if the state was modified by Dehacked? Or is it about a whole FState::CheckCallerType() function?
- Graf Zahl
- Lead GZDoom+Raze Developer
- Posts: 49067
- Joined: Sat Jul 19, 2003 10:19 am
- Location: Germany
Re: [Master] VM Abort when shooting a barrel in Harmony
The other checks would be crash issues, but that particular one needs to be disable for Dehacked-modified states, because the non-Actor functions that can be set here would otherwise cause an abort. All Dehacked-usable functions should contain enough safety checks to not crash.