[Fixed] [bfbf7ff9c]Crash on start-up

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

[bfbf7ff9c]Crash on start-up

Postby Major Cooke » Sat Jan 05, 2019 5:14 pm

In the most recent commits, trying to just start the game causes a crash. It happened from this commit.
Last edited by Major Cooke on Sat Jan 05, 2019 5:23 pm, edited 1 time in total.
User avatar
Major Cooke
Do unto others as you would have unto you. Judge yourself first.
 
Joined: 28 Jan 2007

Re: [bfbf7ff9c]Crash on start-up

Postby Major Cooke » Sat Jan 05, 2019 5:31 pm

Strangely enough, it doesn't crash with debug builds... Pinning it down is proving to be a bit more difficult. However the crash says "illegal instruction".
User avatar
Major Cooke
Do unto others as you would have unto you. Judge yourself first.
 
Joined: 28 Jan 2007

Re: [bfbf7ff9c]Crash on start-up

Postby Major Cooke » Sat Jan 05, 2019 6:28 pm

Found it. It's the "turbo" cvar that's causing a crash when introduced during that commit. Trying to multiply by the defined "scale" double in there is an illegal instruction.
User avatar
Major Cooke
Do unto others as you would have unto you. Judge yourself first.
 
Joined: 28 Jan 2007

Re: [bfbf7ff9c]Crash on start-up

Postby Graf Zahl » Sat Jan 05, 2019 6:32 pm

What's your CPU?`
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [bfbf7ff9c]Crash on start-up

Postby Major Cooke » Sat Jan 05, 2019 6:37 pm

Intel(R) Core(TM) i7-6700HQ CPU @ 2.60GHz (8 CPUs), ~2.6GHz

I'm attaching my DxDiag if it can help.
Attachments
DxDiag.txt
(99.08 KiB) Downloaded 13 times
User avatar
Major Cooke
Do unto others as you would have unto you. Judge yourself first.
 
Joined: 28 Jan 2007

Re: [bfbf7ff9c]Crash on start-up

Postby PlayerLin » Sun Jan 06, 2019 4:58 am

I got same crash(code:C000001D -- illegal instruction -- Address: 000000013F892F7C) after using g3.8pre-83-ga0ad4ea19 x64 of dev. build from DRDTeam dev. builds site, start the game, crashed immediately with GZDooM's very fatal crash error window.

For some reasons...x86 build from the same place just working fine.
Attachments
CrashReport-g3.8pre-83-ga0ad4ea19.zip
Very Fatal Crash Report files by GZDooM(x64 build from DRDTeam dev. builds site)
(17.55 KiB) Downloaded 17 times
User avatar
PlayerLin
 
Joined: 11 Nov 2007
Location: XinZhuang, XinBei/New Taipei City(Former Taipei County), Taiwan.

Re: [bfbf7ff9c]Crash on start-up

Postby phantombeta » Sun Jan 06, 2019 6:11 am

For some reasons...x86 build from the same place just working fine.

That's because this is certainly a problem with the JIT. The JIT doesn't support x86, only x86_64, so it won't crash, since it won't be running in the first place.

EDIT: Hmmmm, maybe not... Though if it isn't this will be hell to figure out.
Last edited by phantombeta on Sun Jan 06, 2019 6:29 am, edited 1 time in total.
User avatar
phantombeta
In the meadow of sinful thoughts, every flower's a perfect one
 
Joined: 02 May 2013
Location: The United Soviet Socialist Dictatorship of Hueland
Discord: phantombeta#2461
Twitch ID: phantombeta_
Github ID: Doom2fan
Operating System: Windows 10/8.1/8 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: [bfbf7ff9c]Crash on start-up

Postby Graf Zahl » Sun Jan 06, 2019 6:24 am

Since I do not get the crash, someone with an affected CPU needs to run the release build in a debugger and tell us what instruction it crashes on. My guess is something with floating point conversions.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [bfbf7ff9c]Crash on start-up

Postby phantombeta » Sun Jan 06, 2019 6:42 am

I can reproduce this with the latest DRD Team build, but not with a self-built build. Something's VERY fucky there.
Also this:
Image

EDIT: Oh, and it's definitely not the JIT. It's crashing inside GZDoom's own code.
User avatar
phantombeta
In the meadow of sinful thoughts, every flower's a perfect one
 
Joined: 02 May 2013
Location: The United Soviet Socialist Dictatorship of Hueland
Discord: phantombeta#2461
Twitch ID: phantombeta_
Github ID: Doom2fan
Operating System: Windows 10/8.1/8 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: [bfbf7ff9c]Crash on start-up

Postby Enjay » Sun Jan 06, 2019 6:48 am

Happening with me too with gzdoom-x64-g3.8pre-83-ga0ad4ea19.7z from DRD. Unfortunately, I have nothing to add other than my crash report.
Attachments
CrashReport.zip
(19.63 KiB) Downloaded 13 times
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: [bfbf7ff9c]Crash on start-up

Postby Graf Zahl » Sun Jan 06, 2019 7:02 am

Since I don't get this, it may be a compiler bug. I am using the latest VC++ 2017. MC uses 2015, AFAIK, but what are the devbuilds compiled with?

@phantombeta: That image is a bit small, can you post something with more lines of code? I'd like to match this with the compiler's assembly output.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [bfbf7ff9c]Crash on start-up

Postby phantombeta » Sun Jan 06, 2019 7:15 am

Gladly.
User avatar
phantombeta
In the meadow of sinful thoughts, every flower's a perfect one
 
Joined: 02 May 2013
Location: The United Soviet Socialist Dictatorship of Hueland
Discord: phantombeta#2461
Twitch ID: phantombeta_
Github ID: Doom2fan
Operating System: Windows 10/8.1/8 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: [bfbf7ff9c]Crash on start-up

Postby drfrag » Sun Jan 06, 2019 7:36 am

AFAIR Blzut3 is using VS 2015.
User avatar
drfrag
I.R developer, I.R smart
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain

Re: [bfbf7ff9c]Crash on start-up

Postby Graf Zahl » Sun Jan 06, 2019 7:43 am

Definitely a code generation error.

Here's the assembly output of the first bad section:

Code: Select allExpand view
   0f 5a d1    cvtps2pd xmm2, xmm1
  00055   f2 0f 59 15 00
   00 00 00    mulsd    xmm2, QWORD PTR __real@3f847ae147ae147b


You can see the first instruction being fully there, but the second one is garbled (but still locatable), there's 3 bytes of garbage in between. To be honest, I don't know how to handle it, someone with a broken compiler needs to do this.
Or we may simply unsupport VC++ 2015 for being buggy.
User avatar
Graf Zahl
Lead GZDoom Developer
Lead GZDoom Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [bfbf7ff9c]Crash on start-up

Postby phantombeta » Sun Jan 06, 2019 7:44 am

Yeah, this is definitely a compiler bug. AppVeyor's VS2015 builds crash too, while the VS2017 builds don't.
User avatar
phantombeta
In the meadow of sinful thoughts, every flower's a perfect one
 
Joined: 02 May 2013
Location: The United Soviet Socialist Dictatorship of Hueland
Discord: phantombeta#2461
Twitch ID: phantombeta_
Github ID: Doom2fan
Operating System: Windows 10/8.1/8 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Next

Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 0 guests