zscript multidimensional arrays?

[gramps]

Does zscript fully support multidimensional arrays?

If I write `int foo[32][16]` and then `foo[17][14] = 123`, I'll get an index out of bounds error.

If I write `int foo[32][16]` and then `foo[15][14] = 123`, I get no error.

In other words it looks like indices for every dimension have to fit within the smallest dimension size, if that makes sense. Either I'm doing something horribly wrong here or there's a nasty bug.

[Apeirogon]

This is bug
viewtopic.php?f=2&t=56491&p=999806&hilit=array#p999806

[gramps]

Huh, so it's backwards?

So just to be clear, if an array were defined in ACS as `int foo[10][20][30]`, then in zscript it should be defined as `int foo[30][20][10]`, right? But when indexing the array, as in `bar = foo[1][2][3]`, it would be the same in both ACS in zscript?

[Graf Zahl]

It's a bug, but unfortunately one buried deep in the parser logic so it's not easily fixable.

[gramps]

Got it, thanks

For anyone else who happens to find this, it does work the way I described in the previous comment... declaration is reversed from ACS, but indexing is the same. The other thing to watch out for is ACS array access is more robust, allowing you to index arrays with out-of-bounds indices (evals to 0), while zscript will not allow this. So you might need some extra guards around your array access in zscript, when porting stuff from ACS.

[Mikk-]

Could this be fixed with versioning? or is that completely impossible and I'm an idiot?

[Graf Zahl]

The problem is not versioning, it's how the compiler frontend constructs types out of the source code. The code is rather badly designed but changing it would risk breaking stuff way beyond the order of array indices.