Extend SKYEXPLODE flag for LineAttack

Moderator: GZDoom Developers

Post Reply
Cacodemon345
Posts: 419
Joined: Fri Dec 22, 2017 1:53 am
Graphics Processor: ATI/AMD (Modern GZDoom)
Contact:

Extend SKYEXPLODE flag for LineAttack

Post by Cacodemon345 »

PR

Introduces:
  • 1. Extended behaviour for LineAttack function; puffs using SKYEXPLODE flag now puffs on skys.
    2. TRACE_HitSky flag; Makes Trace function return TRACE_HasHitSky should the Trace hit a sky floor or ceiling.
User avatar
Nash
 
 
Posts: 17433
Joined: Mon Oct 27, 2003 12:07 am
Location: Kuala Lumpur, Malaysia
Contact:

Re: Extend SKYEXPLODE flag for LineAttack

Post by Nash »

TRACE_HitSky sounds extremely useful. Do these take into account skies generated from Line_Horizon?
User avatar
Rachael
Posts: 13530
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Extend SKYEXPLODE flag for LineAttack

Post by Rachael »

I tested this by modifying BulletPuff directly on my copy of GZDoom. So far I cannot find any potential bugs it introduces, but it needs a second opinion.

I am able to damage monsters, and I was able to test both walls and skies. The puffs still disappear in the sky if the flag is not set, but it spawns a puff as expected with the flag. Thus, I am not able to find any issues, at least so far.
Cacodemon345
Posts: 419
Joined: Fri Dec 22, 2017 1:53 am
Graphics Processor: ATI/AMD (Modern GZDoom)
Contact:

Re: Extend SKYEXPLODE flag for LineAttack

Post by Cacodemon345 »

Nash wrote:TRACE_HitSky sounds extremely useful. Do these take into account skies generated from Line_Horizon?
Ehhh, I made the behaviour of TRACE_HitSky the same as how TRACE_NoSky behaves so that it works properly with LineAttack.
Cacodemon345
Posts: 419
Joined: Fri Dec 22, 2017 1:53 am
Graphics Processor: ATI/AMD (Modern GZDoom)
Contact:

Re: Extend SKYEXPLODE flag for LineAttack

Post by Cacodemon345 »

This should be closed now, as the PR has been merged.
Post Reply

Return to “Closed Feature Suggestions [GZDoom]”