[Added] Extend SKYEXPLODE flag for LineAttack

Moderator: GZDoom Developers

Extend SKYEXPLODE flag for LineAttack

Postby Cacodemon345 » Fri Nov 02, 2018 3:56 am

PR

Introduces:

    1. Extended behaviour for LineAttack function; puffs using SKYEXPLODE flag now puffs on skys.
    2. TRACE_HitSky flag; Makes Trace function return TRACE_HasHitSky should the Trace hit a sky floor or ceiling.
Cacodemon345
 
Joined: 22 Dec 2017
Discord: Cacodemon345#9151
Github ID: Cacodemon345
Operating System: Windows 10/8.1/8 64-bit
Graphics Processor: ATI/AMD (Modern GZDoom)

Re: Extend SKYEXPLODE flag for LineAttack

Postby Nash » Fri Nov 02, 2018 3:57 am

TRACE_HitSky sounds extremely useful. Do these take into account skies generated from Line_Horizon?
User avatar
Nash
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Github ID: nashmuhandes
Operating System: Windows 10/8.1/8 64-bit
Graphics Processor: nVidia with Vulkan support

Re: Extend SKYEXPLODE flag for LineAttack

Postby Rachael » Fri Nov 02, 2018 3:58 am

I tested this by modifying BulletPuff directly on my copy of GZDoom. So far I cannot find any potential bugs it introduces, but it needs a second opinion.

I am able to damage monsters, and I was able to test both walls and skies. The puffs still disappear in the sky if the flag is not set, but it spawns a puff as expected with the flag. Thus, I am not able to find any issues, at least so far.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: Extend SKYEXPLODE flag for LineAttack

Postby Cacodemon345 » Fri Nov 02, 2018 3:59 am

Nash wrote:TRACE_HitSky sounds extremely useful. Do these take into account skies generated from Line_Horizon?
Ehhh, I made the behaviour of TRACE_HitSky the same as how TRACE_NoSky behaves so that it works properly with LineAttack.
Cacodemon345
 
Joined: 22 Dec 2017
Discord: Cacodemon345#9151
Github ID: Cacodemon345
Operating System: Windows 10/8.1/8 64-bit
Graphics Processor: ATI/AMD (Modern GZDoom)

Re: Extend SKYEXPLODE flag for LineAttack

Postby Cacodemon345 » Sat Nov 03, 2018 9:25 am

This should be closed now, as the PR has been merged.
Cacodemon345
 
Joined: 22 Dec 2017
Discord: Cacodemon345#9151
Github ID: Cacodemon345
Operating System: Windows 10/8.1/8 64-bit
Graphics Processor: ATI/AMD (Modern GZDoom)


Return to Closed Feature Suggestions

Who is online

Users browsing this forum: No registered users and 1 guest