Make StatusScreen::End virtual

Moderator: GZDoom Developers

Post Reply
User avatar
Marrub
 
 
Posts: 1192
Joined: Tue Feb 26, 2013 2:48 pm
Preferred Pronouns: No Preference
Operating System Version (Optional): Arch Linux
Graphics Processor: ATI/AMD with Vulkan/Metal Support
Contact:

Make StatusScreen::End virtual

Post by Marrub »

Currently there is no way to do something when an intermission screen exits besides overriding all functions that call End(), so it would be rather convenient to be able to just override it and do stuff there.
ZippeyKeys12
Posts: 111
Joined: Wed Jun 15, 2016 2:49 pm

Re: Make StatusScreen::End virtual

Post by ZippeyKeys12 »

User avatar
Rachael
Posts: 13532
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Make StatusScreen::End virtual

Post by Rachael »

Zippey are these being properly tested before you submit them? If so, what exactly is the procedure by which you go about doing so?

I'm not saying anything's wrong with it, but you're going a bit quick with them and that concerns me.
ZippeyKeys12
Posts: 111
Joined: Wed Jun 15, 2016 2:49 pm

Re: Make StatusScreen::End virtual

Post by ZippeyKeys12 »

I have 3 gzdoom repos on my computer, small stuff, INI parser export and per-mod storage. When one is compiling I work on the other. Once it compiles I go through all the compiler warnings to see if it is from any changes of mine. Then I make a test wad testing every function added or changed and play through map 1 of freedoom. Rinse and repeat.
The 3 PR's are for super easy stuff, that's why it was so quick.
User avatar
Rachael
Posts: 13532
Joined: Tue Jan 13, 2004 1:31 pm
Preferred Pronouns: She/Her
Contact:

Re: Make StatusScreen::End virtual

Post by Rachael »

Fair enough.
ZippeyKeys12
Posts: 111
Joined: Wed Jun 15, 2016 2:49 pm

Re: Make StatusScreen::End virtual

Post by ZippeyKeys12 »

This can be [Added]
Post Reply

Return to “Closed Feature Suggestions [GZDoom]”