Soft poly issues on Valhalla map

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.
Post Reply
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Soft poly issues on Valhalla map

Post by _mental_ »

Loading Valhalla with software poly renderer (true color or not) crashes the current master branch.
Spoiler: Callstack
CurrentViewpoint is nullptr while viewport passed to RenderPolyScene::RenderTranslucent() function seems to be valid.
Last edited by _mental_ on Sun Apr 15, 2018 8:29 am, edited 1 time in total.
dpJudas
 
 
Posts: 3036
Joined: Sat May 28, 2016 1:01 pm

Re: Soft poly crashes on Valhalla

Post by dpJudas »

Fixed.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: Soft poly crashes on Valhalla

Post by _mental_ »

It still crashes but at a different location
Spoiler: Callstack
Viewpoint.camera is nullptr.
dpJudas
 
 
Posts: 3036
Joined: Sat May 28, 2016 1:01 pm

Re: Soft poly crashes on Valhalla

Post by dpJudas »

Hmm, at the spawn position? Been playing the map for a few minutes now without it crashing.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: Soft poly crashes on Valhalla

Post by _mental_ »

Yes, it's 100% to me. Tried several times with vid_rendermode set to 2 or 3.
dpJudas
 
 
Posts: 3036
Joined: Sat May 28, 2016 1:01 pm

Re: Soft poly crashes on Valhalla

Post by dpJudas »

I can't really reproduce it here, but I added some null pointer checks on the camera access. Did that fix the crash?
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: Soft poly issues on Valhalla map

Post by _mental_ »

This fixed the crash. The problem is after sprites are not rendered at all including player's weapon.
Also, bunch of walls are not visible in soft poly (at spawn position) leading to significantly different picture in comparison with other renderers.
Probably these are two unrelated issues. IWAD maps work fine like before.
dpJudas
 
 
Posts: 3036
Joined: Sat May 28, 2016 1:01 pm

Re: Soft poly issues on Valhalla map

Post by dpJudas »

Pushed some fixes that should make the portal rendering a lot more stable now.
_mental_
 
 
Posts: 3812
Joined: Sun Aug 07, 2011 4:32 am

Re: Soft poly issues on Valhalla map

Post by _mental_ »

Almost there, OpenGL vs Soft Poly TC
ma_val-comp.jpg
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
Posts: 49053
Joined: Sat Jul 19, 2003 10:19 am
Location: Germany

Re: Soft poly issues on Valhalla map

Post by Graf Zahl »

I remember having had to fix the same thing in the hardware renderer when the map was new. That structure extends into the sky ceiling, if I am not mistaken. It's not the only issue with the softpoly renderer. When I checked the SiD-crate it also did not display properly. My guess is that softpoly has little to no support for render hacks, but I never did a deeper check for that.
The renderer was listed as 'experimental' for good reasons.
dpJudas
 
 
Posts: 3036
Joined: Sat May 28, 2016 1:01 pm

Re: Soft poly issues on Valhalla map

Post by dpJudas »

Softpoly doesn't have any real support for render hacks and its portal support is incomplete/broken. What I fixed was a regression where even encountering such stuff caused things to blink and even sometimes crash. Particular crashes I want to never happen because then at least you can switch to another renderer.
Post Reply

Return to “Closed Bugs [GZDoom]”