Skies still having issues

[Hellser]

Skies are still having an issue. It would appear that the bug is more than just sky transfers. I've not tested how GZDoom reacts to patch-replaced tall skies (as in, one that isn't transfered) until now.

The original bug exists with a patch replacement sky. Meaning GZDoom is rather derpy with tall skies (skies over 128+ in height).

Transfered skies are now producing a new type of bug; most likely relating to the actual bug as seen above.


Might want to undo that original commit and see why GZDoom is going derpy when tall skies comes into play. Please note that tall skies can range from 128-256. Maybe even taller.

[Cacodemon345]

The commit fix applies a mere offset.

[Graf Zahl]

I reverted Mentals commit because it was the cause of the color problem.

The original report isn't a positioning bug. Heretic and Hexen place 200 pixel tall screens with the bottom at the center. If you want it to go lower you have to use a taller sky.
Yes it is suboptimal but cannot be helped.

[Hellser]

Would it be possible to run a check to see if Doom is loaded as a game then apply a fix?

[Graf Zahl]

No. We cannot just randomly change behavior like that. It would break lots of mods out there with 200 pixel tall skies.

There's one thing you can do which will at least work with the GL renderer and with the capped software sky renderer (but not the classic software version): You can set a "skyoffset" for your sky in ANIMDEFS:

Code: Select all

skyoffset sky7 -36

[Hellser]

That'll work I suppose. Thanks.