[Fixed] ACS string table corruption

[Marrub]

Summary 0000590
ACS string table corruption

Description
Same as issue 0000441 but, apparently, it's not save games causing this. Strings are just getting shuffled around in the string table, for some reason.

Additional Information
The attached save file uses doom2.wad and http://mab.greyserv.net/f/Lithium_1_4.pk7

Files
save30.zds

[Marrub]

Forgot to add, the save is running 2.4.0. (Though that could be determined by just looking inside the file.)
You can reproduce the issue by grabbing the plasma rifle in front of the player, but there's also corrupted strings in the log tab in the menu.

[Graf Zahl]

Sorry, but this is pretty much undebuggable.
The biggest roadblock are those ACS binaries which I cannot decompile or disassemble to rule out bad code generation as a culprit. To use dynamic strings from ACS libraries they need to follow very strict procedures of how to deal with strings. So far every time someone reported string corruption it was caused by badly generated byte code.

I need something smaller and more contained where I am capable of seeing what the scripts are actually doing. This is 1.8 MB of ACS binary code, all of which may indirectly be responsible for the problems.

[wildweasel]

I'd like to amend this report by saying that FInal Doomer Plus (found at https://forum.zdoom.org/viewtopic.php?f=43&t=55061) also exhibits this glitch; weapon descriptions (invoked by holding Reload) will sometimes change into a letter A. I'd managed to trigger this with the Plutonia machine gun, but don't have a save file handy ([edit]: for what it's worth, though, it may have exhibited by use of autosaves).

[Marrub]

Yeah, a lot of people are getting this bug, and the code is maybe 60 lines of vanilla ACS... That's kind of worrying.

[phantombeta]

Wasn't this one fixed?

[Graf Zahl]

It probably is - then again - maybe not. Who knows if it was the same thing, like I said this was undebuggable.

[phantombeta]

It probably is - then again - maybe not. Who knows if it was the same thing, like I said this was undebuggable.

It was most definitely the exact same bug Final Doomer had, there's literally zero doubt about that.

[_mental_]

Most likely, it was this bug. I don't remember that something like this was reported after the given change.