[Fixed] [MBF21] Axe in Vesper plays chainsaw sounds

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

[MBF21] Axe in Vesper plays chainsaw sounds

Postby Marisa the Magician » Tue Jun 07, 2022 3:39 am

Exactly what it says on the tin. While in its ready state, the vanilla chainsaw idle sound plays repeatedly. This isn't supposed to happen.
User avatar
Marisa the Magician
ZScript Crimester
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: Marisa the Magician#1666
Twitch ID: MarisaDOOM
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: [MBF21] Axe in Vesper plays chainsaw sounds

Postby Graf Zahl » Tue Jun 07, 2022 4:23 am

Same as viewtopic.php?f=2&t=75535 , most likely.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [MBF21] Axe in Vesper plays chainsaw sounds

Postby Graf Zahl » Wed Jun 08, 2022 2:14 pm

I have to admit that I have no idea how to debug this. All I have for reference is the Dehacked file which gives me zero clues what to look for.
This will be an ongoing problem with MBF21 - unlike DECORATE or ZScript the 'code' is way too messy.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [MBF21] Axe in Vesper plays chainsaw sounds

Postby boris » Tue Jun 14, 2022 4:15 pm

Not sure if that helps, but the Vesper DECOHack source is available at https://github.com/XaserAcheron/vesper.

From that it should be possible to create a Dehacked patch that only contains the axe.
boris
I post less than Manc and Hobo
 
Joined: 15 Jul 2003

Re: [MBF21] Axe in Vesper plays chainsaw sounds

Postby InsanityBringer » Tue Jun 14, 2022 10:00 pm

The problem from what I can tell is that zdoom plays a weapons ReadySound whenever A_WeaponReady is called on the state right under the Ready label, but vanilla only plays the chainsaw idle sound when its called on the state S_SAW and the current weapon is the chainsaw. The axe in Vesper explicitly doesn't use the state S_SAW to avoid playing the sound at all.

This seems like it's going to be tricky to work around.
User avatar
InsanityBringer
 
Joined: 05 Jul 2007
Location: opening the forbidden box
Discord: InsanityBringer#9908

Re: [MBF21] Axe in Vesper plays chainsaw sounds

Postby Graf Zahl » Wed Jun 15, 2022 12:08 am

Fortunately Dehacked never had access to the ready sound property, so I think what can be done is to let Dehacked clear it for all weapons it touched that do not link to the S_SAW state.
I'm a bit surprised this never came up before - the bug had been there for all eternity - it got added in the early 1.23 versions some 20 years ago.
Apparently it is exceedingly rare for Dehacked patches to remap the states for disabling this sound...
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [MBF21] Axe in Vesper plays chainsaw sounds

Postby Graf Zahl » Wed Jun 15, 2022 2:05 pm

Should be better now. Let's hope that I didn 't miss some other edge case.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 1 guest