Stat screens no longer play scope? [336c45a]

AFADoomer · Post by **AFADoomer** » Sat May 07, 2022 8:42 am

Maybe not a bug, but intended design... Since commit 336c45a, stat screens now run in ui scope instead of play scope (despite the line at the top of statscreen.zs that still states "Note that the status screen needs to run in 'play' scope!").

This makes previously trivial actions like giving the player a reward inventory item or adding score points for hitting completion percentages obnoxiously complicated.

Post by **Graf Zahl** » Sat May 07, 2022 9:03 am

Well, I'm afraid but this turned out to be a major blocker for refactoring the intermission code. The old one had to run in play scope because it needed access to the network state. The new code runs entirely in UI scope and only syncs with the game right at the end, after all screens have run. This setup no longer allows running play stuff in there.

I was well aware that this may break a small number of mods doing weird things but in this case the price to pay for these mods would be being locked into a poorly designed and non-extensible intermission system for all eternity.

AFADoomer · Post by **AFADoomer** » Sat May 07, 2022 9:42 am

I assumed as much... No worries.

Thanks for clarification!

EDIT: Except that I have to completely rework things since network events get ignored if the game isn't in gamestate of GS_LEVEL... So I can't just use a network event to trigger the bonus item to be added.

ZDoom