[Fixed] NoTrim option isn't recognized

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

NoTrim option isn't recognized

Postby Jekyll Grim Payne » Wed Apr 27, 2022 5:29 am

NoTrim is a TEXTURES flag and an ANIMDEFS keyword that was added following my suggestion.

It doesn't seem to work at all. I tried it yesterday on g4.8pre-321-gecc0afd2f.

If specified in TEXTURES it produces no visible effect, and if I try to add it via ANIMDEFS (which should be possible according to this https://zdoom.org/wiki/ANIMDEFS#Other), it actually produces a "bad syntax" error, so it doesn't seem to be recognized at all.

I don't feel an example is particularly necessary but I made one anyway.

TEXTURES issue: I made a pistol version with PISGF0 sprite that has empty canvas twice as tall as the sprite itself. It's continuously rotated at the center, which should be the iron sight given the empty canvas, but it's rotated around the graphic's center instead.

ANIMDEFS issue: uncomment the "Notrim PISGF0" line in ANIMDEFS, and GZDoom won't start.
You do not have the required permissions to view the files attached to this post.
User avatar
Jekyll Grim Payne
 
 
 
Joined: 21 Jul 2008
Discord: Agent_Ash#4401
Github ID: jekyllgrim
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia (Modern GZDoom)

Re: NoTrim option isn't recognized

Postby Blue Shadow » Thu Apr 28, 2022 11:25 am

This commit seems to have reverted a change related to this feature.

As for the ANIMDEFS error, either the wiki is wrong, or the feature was implemented in the wrong place. As it stands, it requires that a texture animation definition is created:

Code: Select allExpand view
texture PISGF0 NoTrim
User avatar
Blue Shadow
 
Joined: 14 Nov 2010
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: ATI/AMD (Modern GZDoom)

Re: NoTrim option isn't recognized

Postby Graf Zahl » Thu Apr 28, 2022 12:02 pm

Blue Shadow wrote:This commit seems to have reverted a change related to this feature.


What part?`
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: NoTrim option isn't recognized

Postby Blue Shadow » Thu Apr 28, 2022 1:04 pm

The bit in gametexture.cpp.
User avatar
Blue Shadow
 
Joined: 14 Nov 2010
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: ATI/AMD (Modern GZDoom)

Re: NoTrim option isn't recognized

Postby Jekyll Grim Payne » Sat Apr 30, 2022 1:23 pm

Blue Shadow wrote:This commit seems to have reverted a change related to this feature.

As for the ANIMDEFS error, either the wiki is wrong, or the feature was implemented in the wrong place. As it stands, it requires that a texture animation definition is created:

Code: Select allExpand view
texture PISGF0 NoTrim


I amended the wiki entry, and the new syntax seems at least recognized (I'm rather confused that it seems to require the word "texture" regardless of the actual namespace of the graphic, though).

So, I assume this was reverted by accident?
User avatar
Jekyll Grim Payne
 
 
 
Joined: 21 Jul 2008
Discord: Agent_Ash#4401
Github ID: jekyllgrim
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia (Modern GZDoom)

Re: NoTrim option isn't recognized

Postby Graf Zahl » Sat Apr 30, 2022 1:46 pm

Yes. It happened when I made a backend sync between Raze and GZDoom and copied in the wrong direction.
Regarding the keyword, this was a PR, so apparently this was overlooked.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: NoTrim option isn't recognized

Postby Blue Shadow » Sat Apr 30, 2022 3:00 pm

Jekyll Grim Payne wrote:(I'm rather confused that it seems to require the word "texture" regardless of the actual namespace of the graphic, though).

To clarify, as it's currently implemented, NoTrim is a command of a texture animation definition, such as ALLOWDECALS.
User avatar
Blue Shadow
 
Joined: 14 Nov 2010
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: ATI/AMD (Modern GZDoom)


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 1 guest