[Fixed] [4.8-d05ea19] Pink hued textures with material textures

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Forum rules
Please don't bump threads here if you have a problem - it will often be forgotten about if you do. Instead, make a new thread here.

[4.8-d05ea19] Pink hued textures with material textures

Postby grahf78 » Tue Apr 05, 2022 4:38 pm

Textures have a strong pinkish hue when they have PBR materials and brightmaps associated to them. See screenshots below.

The issue does not happen in gzdoom 4.7.1, nor with the other renderers. Attached a reproducible sample.

4.8.0-pre:



4.7.1:

You do not have the required permissions to view the files attached to this post.
Last edited by grahf78 on Tue Apr 05, 2022 8:35 pm, edited 1 time in total.
grahf78
 
Joined: 21 Jun 2020
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia (Modern GZDoom)

Re: [4.8-d05ea19] Pink hued textures with material textures

Postby Enjay » Tue Apr 05, 2022 6:24 pm

I can't run your example. I get:
Code: Select allExpand view
**** DIED WITH FATAL ERROR:
Shader 'test' could not be linked:
ERROR: Linking fragment stage: No function definition (body) found:
    Process(vf4;
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: [4.8-d05ea19] Pink hued textures with material textures

Postby grahf78 » Tue Apr 05, 2022 8:36 pm

My previous sample only worked with the GLES renderer. I've updated it to also work with Vulkan/OpenGL.
grahf78
 
Joined: 21 Jun 2020
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia (Modern GZDoom)

Re: [4.8-d05ea19] Pink hued textures with material textures

Postby Enjay » Wed Apr 06, 2022 11:29 am

Ah right. I assumed from when you mentioned "other renderers" it should start in them all. With the new sample, I can confirm that on my RTX 2060, the sample is pink in GLES and white in Vulkan with g4.8pre-273-gd05ea1965 and also white in GLES in 4.7.1.
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: [4.8-d05ea19] Pink hued textures with material textures

Postby emile_b » Wed Apr 20, 2022 12:39 pm

OK I found the issue, the problem is gl_customshader can be true in GLES now due to this commit:
https://github.com/coelckers/gzdoom/com ... b62a9deea4

So the mShaderIndex gets set to a custom shader which the GLES backend does not know what to do with.

I suppose the question is should gl_customshader be CVAR_ARCHIVE? Does it need to be saved and is it expected to ever be used by the user?
emile_b
 
Joined: 22 Sep 2019
Operating System: Windows 10/8.1/8/201x 64-bit
Graphics Processor: nVidia (Modern GZDoom)

Re: [4.8-d05ea19] Pink hued textures with material textures

Postby Rachael » Wed Apr 20, 2022 9:11 pm

The intent was to allow the user to turn off shaders when they get too heavy for a system even on Vulkan/OpenGL. It's possible to overload shader clocks on older GL 4.x systems very easily.
User avatar
Rachael
^ walking stack of unfinished projects ^
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle

Re: [4.8-d05ea19] Pink hued textures with material textures

Postby Graf Zahl » Wed Apr 20, 2022 11:51 pm

Yeah, but you can't do it like this. There's code depending on that CVAR that may not run in GLES mode.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [4.8-d05ea19] Pink hued textures with material textures

Postby Rachael » Thu Apr 21, 2022 12:51 am

User avatar
Rachael
^ walking stack of unfinished projects ^
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 2 guests