[Fixed] crash with SetViewPos / ViewPosition class

[crashm]

I've included a sample pk3 that's just a playerpawn with a Tick() override that calls SetViewPos, all you have to do to get it to crash with a Very Fatal Error is start a new game, save, then load a few times.

Checking it out in the Visual Studio debugger seems to show that the engine is trying to destroy a ViewPosition object that doesn't exist.

[Graf Zahl]

Looks like this was not properly implemented. The data being used here was not properly declared for the garbage collector.

[Major Cooke]

Apologies for this. I was trying to go by how you suggested the overhaul be like for things like sprite rolling where data's minimized and only called when needed.

If there's a better way to handle this from here on out, I'd love to know.

[Graf Zahl]

It's not that complicated. If you declare a pointer to a DObject-derived class, you need to add two things:

First, wrap the pointer in a TObjPtr and second, add a declaration to the containing class's pointer list. These two things are needed so that the GC can properly handle the object. What happened here is that the GC threw out the ViewPos object because it did not know about it but left the stale pointer untouched, which obviously resulted in a crash.