[Fixed] Crash when starting a map with several scrollers

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Crash when starting a map with several scrollers

Postby printz » Sun Dec 26, 2021 2:43 am

I'm on a Mac (if relevant) and trying to load a test map with several types of scrollers. I'm using the DRDTeam devbuild of gzdoom-g4.8pre-83-g54ad3433b.zip. The level contains several uses of the Scroll_Texture_Offsets action special, with both documented and undocumented flags being used (the undocumented ones are necessary to support the equivalent MBF21 Boom specials).

The attached zip contains the map and the crash log.

scroll-udmf.zip
You do not have the required permissions to view the files attached to this post.
User avatar
printz
Eternity, Eureka and AutoDoom programmer
 
Joined: 26 Oct 2006
Location: Bucharest, Romania
Github ID: ioan-chera
Operating System: Windows 10/8.1/8/201x 64-bit

Re: Crash when starting a map with several scrollers

Postby Player701 » Mon Dec 27, 2021 5:30 am

The problem is in this line. The condition should be to check if the value of it.Next() is non-negative, otherwise it eventually returns -1 and everything goes boom because this value is used as an array index. I've submitted a PR to fix this here.
User avatar
Player701
 
 
 
Joined: 13 May 2009
Location: Russia
Discord: Player701#8214
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 1 guest