[Closed] Overlay models not working in gzdoom 4.7.1 - SOLVED

[ramon.dexter]

I've noticed that the android version of gzdoom (Delta Touch) don't display overlayed models. Also, gzdoom 4.7.1 on my work laptop with intel HD 5500, which support opengl 4.4, dont display overlay models either. Overlays with sprites work fine, but models dont. Is it related to opengl version? Or is it some bug on engine or renderer itself?

edit: TESTING FILE
here's smaller file: https://drive.google.com/file/d/17pKLLkmAlWveSfp5nJIkHybKY5l42Xhc/view?usp=sharing
80MB still, but I cannot make it smaller. Since the overlay has to work with new weapons, I also need to include the new weapons. Sorry.

Testing case: drop it over gzdoom.exe, select STRIFE1.wad.
Start a new game, difficulty doesnt matter.
When the game loads, type open console and type "puke 4201", this will give you starting gear and the shouldergun, that works in overlay.
Default key to shoot shoudlergun is F, but it also could be fired by activating in inventory.

As I have tested, the overlay model works correctly in gzdoom 4.6.1 under all renderers that show models. Model overlay don't work in gzdoom 4.7.1 and newer. Also, as I have tested, even sprite overlays don't work in 4.7.1.
As I have tested later, in 4.8 pre-252 sprite overlays work, but model overlays not. Tested under opengl and vulkan.

[Rachael]

Yep, that's a bug.

Unfortunately I had a major system failure with my old system so I can't really test this right now. I've moved the topic to the appropriate section though.

What we will need though, is a test case of the models failing to work, so if you could attach an example somewhere that would be really helpful.

[ramon.dexter]

Thanks for the move. I wasn't sure if it is a bug or intended behaviour.

Here's the test file. https://drive.google.com/file/d/1BFuuEQtTZEarhg_Y3yyBdsa5VRvdMcnq/view?usp=sharing

Testing case: it needs strife1.wad OR strife sve to run.

Drop it all over gzdoom.exe and run it. Difficulty dont matter, but I'm testing it on rookie.
When the map loads, open console and type in 'puke 4201'.
The overlayed model is the shouldergun inventory item. It is fired by pressing the default 'F' key or by selecting in inventory and using it.

The overlay model works fine on my main laptop with nvidia rtx2060. On android ports (running opengl es, I think) it dont display overlayed models, also on the intel HD5500 (opengl 4.4) the model is invisible.

[ramon.dexter]

As I have found out, in gzdoom 4.7.1 the overlays models dont work even in newer opengl or in vulkan. Gzdoom 4.6.1 works fine. I cannot confirm working on android, since delta touch automatically updated to latest version with gzdoom 4.7.1.

[drfrag]

Then it's not a GLES bug.

[ramon.dexter]

Another update, I was able to get an older version of Delta Touch with gzdoom 4.6.1, and the overlay models work there. So this is definitely a bug of gzdoom, not a renderer issue.

[ramon.dexter]

Okay, may I know...how is this bug being treated?

[Major Cooke]

Kinda hard to debug without an example.

But I should note that any changes I made to overlays shouldn't have any impact on models.

[ramon.dexter]

I already posted an example, three posts up it cannot be downloaded?
edit: I have tested the 4.8 pr-252. Sprite overlays work, yet the model overlays don't.

edit:
here's smaller file: https://drive.google.com/file/d/17pKLLkmAlWveSfp5nJIkHybKY5l42Xhc/view?usp=sharing
80MB still, but I cannot make it smaller. Since the overlay has to work with new weapons, I also need to include the new weapons. Sorry.

Testing case: drop it over gzdoom.exe, select STRIFE1.wad.
Start a new game, difficulty doesnt matter.
When the game loads, type open console and type "puke 4201", this will give you starting gear and the shouldergun, that works in overlay.
Default key to shoot shoudlergun is F, but it also could be fired by activating in inventory.

As I have tested, the overlay model works correctly in gzdoom 4.6.1 under all renderers that show models. Model overlay don't work in gzdoom 4.7.1 and newer. Also, as I have tested, even sprite overlays don't work in 4.7.1.
As I have tested later, in 4.8 pre-252 sprite overlays work, but model overlays not. Tested under opengl and vulkan.

[Kizoky]

I already posted an example, three posts up it cannot be downloaded?
edit: I have tested the 4.8 pr-252. Sprite overlays work, yet the model overlays don't.

edit:
here's smaller file: https://drive.google.com/file/d/17pKLLkmAlWveSfp5nJIkHybKY5l42Xhc/view?usp=sharing
80MB still, but I cannot make it smaller. Since the overlay has to work with new weapons, I also need to include the new weapons. Sorry.

Testing case: drop it over gzdoom.exe, select STRIFE1.wad.
Start a new game, difficulty doesnt matter.
When the game loads, type open console and type "puke 4201", this will give you starting gear and the shouldergun, that works in overlay.
Default key to shoot shoudlergun is F, but it also could be fired by activating in inventory.

As I have tested, the overlay model works correctly in gzdoom 4.6.1 under all renderers that show models. Model overlay don't work in gzdoom 4.7.1 and newer. Also, as I have tested, even sprite overlays don't work in 4.7.1.
As I have tested later, in 4.8 pre-252 sprite overlays work, but model overlays not. Tested under opengl and vulkan.

There was an update to models not long ago how the overlay models should be defined in modeldef
Instead of defining the overlay weapon in the weapon that will be shown, you need to define the overlay weapon itself so you don't need to duplicate it if you wish to use the same overlay weapon in multiple weapons over and over again

[ramon.dexter]

There was an update to models not long ago how the overlay models should be defined in modeldef
Instead of defining the overlay weapon in the weapon that will be shown, you need to define the overlay weapon itself so you don't need to duplicate it if you wish to use the same overlay weapon in multiple weapons over and over again

Okay, is there any more info, or any example? I would love to solve this issue and finally update my gzdoom, especially on android...

Also, I have to note that the overlay I'm using is technically not a weapon, but a CustomInventory. Does this matter?

[ramon.dexter]

Okay, thanks to Kizoky, case is closed. The bug was caused by recent change in modeldef on how model overlays are being treated. So, instead of defining the overlays into each weapon that has to be affected by the overlay, the model has to be defined as a separate model definition. Cut the talk, here's an example:

How it should NOT be defined:

Code: Select all • Expand view

//definition of overlays in each of weapons - this no longer work
//example of one of the weapons
model zscPunchDagger {
   //  start  //
   path "models/weapons/shoulderGun/"
   model 0 "shoulderGun.md3"
   skin 0 "tx_shoulderGun2_px.png"
   scale 1.25 1.25 1.25
   offset -13.0 -20.0 5.0
   
   frameindex SHCN A 0 1
   frameindex SHCN D 0 1
   frameindex SHCN E 0 1
   frameindex SHCN F 0 1
   frameindex SHCN G 0 1
   frameindex SHCN H 0 1
   frameindex SHCN I 0 1
   //////////////////////////////
   
   //  shoot //   
   offset -13.0 -19 5.0   
   frameindex SHCN J 0 1
   frameindex SHCN C 0 1   
   offset -13.0 -18.0 5.0      
   frameindex SHCN B 0 1   
   //////////////////////////////
   
   //  show/hide  //
   path "models/weapons/shoulderGun/"
   model 0 "shoulderGun.md3"
   skin 0 "tx_shoulderGun2_px.png"
   scale 1.25 1.25 1.25
   offset -13.0 -20.0 5.0   
   frameindex SHCH A 0 1   
   offset -13.0 -18.0 5.0   
   frameindex SHCH B 0 1   
   offset -13.0 -16.0 5.0   
   frameindex SHCH C 0 1
   offset -13.0 -14.0 5.0   
   frameindex SHCH D 0 1
   offset -13.0 -12.0 5.0   
   frameindex SHCH E 0 1
   offset -13.0 -10.0 5.0   
   frameindex SHCH F 0 1
   offset -13.0 -6.0 5.0   
   frameindex SHCH G 0 1
   offset -13.0 -2.0 5.0   
   frameindex SHCH H 0 1
   offset -13.0 2.0 5.0   
   frameindex SHCH I 0 1
   offset -13.0 6.0 5.0   
   frameindex SHCH J 0 1
   //////////////////////////////
}


How it SHOULD BE defined:

Code: Select all • Expand view

//overlays defined only in the inventory item, that makes and displays the overlays
model shoulderGun {   
   path "models/weapons/shoulderGun/"
   model 0 "p_shoulderGun.md3"
   skin 0 "tx_shoulderGun2_px.png"
   scale 1.35 1.35 1.35
   offset 0.0 0.0 0.0
   frameindex DUMM A 0 0   

   //  start  //
   path "models/weapons/shoulderGun/"
   model 0 "shoulderGun.md3"
   skin 0 "tx_shoulderGun2_px.png"
   scale 1.25 1.25 1.25
   offset -13.0 -20.0 5.0
   
   frameindex SHCN A 0 1
   frameindex SHCN D 0 1
   frameindex SHCN E 0 1
   frameindex SHCN F 0 1
   frameindex SHCN G 0 1
   frameindex SHCN H 0 1
   frameindex SHCN I 0 1
   //////////////////////////////
   
   //  shoot //   
   offset -13.0 -19 5.0   
   frameindex SHCN J 0 1
   frameindex SHCN C 0 1   
   offset -13.0 -18.0 5.0      
   frameindex SHCN B 0 1   
   //////////////////////////////
   
   //  show/hide  //
   path "models/weapons/shoulderGun/"
   model 0 "shoulderGun.md3"
   skin 0 "tx_shoulderGun2_px.png"
   scale 1.25 1.25 1.25
   offset -13.0 -20.0 5.0   
   frameindex SHCH A 0 1   
   offset -13.0 -18.0 5.0   
   frameindex SHCH B 0 1   
   offset -13.0 -16.0 5.0   
   frameindex SHCH C 0 1
   offset -13.0 -14.0 5.0   
   frameindex SHCH D 0 1
   offset -13.0 -12.0 5.0   
   frameindex SHCH E 0 1
   offset -13.0 -10.0 5.0   
   frameindex SHCH F 0 1
   offset -13.0 -6.0 5.0   
   frameindex SHCH G 0 1
   offset -13.0 -2.0 5.0   
   frameindex SHCH H 0 1
   offset -13.0 2.0 5.0   
   frameindex SHCH I 0 1
   offset -13.0 6.0 5.0   
   frameindex SHCH J 0 1
   //////////////////////////////
}


I tested it with the latest dev build 4.8pre-276-g3d1ddbc80 under opengl, opengl-es and vulkan. Also works under 4.7.1 stable. Case solved.