[Fixed] Crossfade melt + Strife broken

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Crossfade melt + Strife broken

Postby Nash » Fri Oct 29, 2021 7:46 am

I suspect it was because of this commit: https://github.com/coelckers/gzdoom/com ... 38fc8f32cd

Steps to reproduce:

1) Load up Strife
2) Set the screen melt to crossfade
3) Start a new game. Fade looks fine for now...
4) Kill yourself and resurrect
5) Observe the broken crossfade

Only happens with Vulkan. OpenGL is fine

I could only repro it with Strife. Doom doesn't seem to exhibit the issue.
User avatar
Nash
AKA Nash Muhandes! Twitter/Facebook/Youtube: nashmuhandes
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Twitch ID: nashmuhandes
Github ID: nashmuhandes

Re: Crossfade melt + Strife broken

Postby Enjay » Fri Oct 29, 2021 9:54 am

I take it you mean this big white cross?

I can get it right from first start - no need to kill and resurrect.

I can also get it with Doom and I also get this strange red line from the 1 on the HUD:


What's more, I even thought I'd noticed an effect similar to the red line with other screen transition modes when completing a level However, it was happening so quickly, that I wasn't convinced that I was seeing it. So maybe that's a separate bug?
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: Crossfade melt + Strife broken

Postby Nash » Fri Oct 29, 2021 10:07 am

I didn't get the white cross - what I got was what appears to be broken map geometry. I'm unable to take any screenshots right now, unfortunately.

If anything, this is saying that the way the glitch manifests seems to be different from system to system.
User avatar
Nash
AKA Nash Muhandes! Twitter/Facebook/Youtube: nashmuhandes
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Twitch ID: nashmuhandes
Github ID: nashmuhandes

Re: Crossfade melt + Strife broken

Postby Enjay » Fri Oct 29, 2021 1:23 pm

Here's a quick screenshot when starting a game with the screen transition set to Burn.


It was only there momentarily, but I assume the medpack was from the full screen HUD.
[edit]Looking at the first Doom pic I posted - it could be my imagination but it looks like there might be a hint of red in the middle at roughly the same position as where the red cross on the medpack appears in the above shot. Maybe.[/edit]

Here's what I saw when changing to the status bar.


Again, it was only there momentarily (quite hard to screenshot). However, that could be mistaken for seeing messed up map geometry. Perhaps that's a similar effect to what you (Nash) saw in Strife?
[edit] Status bar shot from Strife:

[/edit]
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: Crossfade melt + Strife broken

Postby dpJudas » Fri Oct 29, 2021 1:36 pm

It seems like a random texture is being bound instead of the right one. What I don't understand is how this commit can cause this as it doesn't touch descriptor bindings at all.
dpJudas
 
 
 
Joined: 28 May 2016

Re: Crossfade melt + Strife broken

Postby Enjay » Fri Oct 29, 2021 1:50 pm

Assuming that you are meaning the "map geometry" pics, it's not a random texture, in both cases it's the one used as the background around the screen where the status bar doesn't cover it (the borderflat).
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: Crossfade melt + Strife broken

Postby Nash » Fri Oct 29, 2021 2:02 pm

Enjay wrote:Here's what I saw when changing to the status bar.


Again, it was only there momentarily (quite hard to screenshot). However, that could be mistaken for seeing messed up map geometry. Perhaps that's a similar effect to what you (Nash) saw in Strife?
[edit] Status bar shot from Strife:

[/edit]


Yeah, this is what I am seeing with Strife. I play with the status bar on.

dpJudas wrote:It seems like a random texture is being bound instead of the right one. What I don't understand is how this commit can cause this as it doesn't touch descriptor bindings at all.


Sorry if my suspicions were incorrect. :) It's just that there are so few commits between the 4.7.1 release and the latest master - there's only 1 Vulkan-related commit since then, so I assumed that commit was somehow related to this bug.
User avatar
Nash
AKA Nash Muhandes! Twitter/Facebook/Youtube: nashmuhandes
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Twitch ID: nashmuhandes
Github ID: nashmuhandes

Re: Crossfade melt + Strife broken

Postby dpJudas » Fri Oct 29, 2021 2:25 pm

Managed to track it down. Here's the pull request fixing it.
dpJudas
 
 
 
Joined: 28 May 2016

Re: Crossfade melt + Strife broken

Postby SanyaWaffles » Fri Oct 29, 2021 6:51 pm

Can confirm this was a problem. I thought at first my graphics card shat the bed.

Glad to see it fixed so quickly.
User avatar
SanyaWaffles
Certified Heretic and Grill Champion
 
Joined: 25 Apr 2013
Location: Disappointment Island
Discord: SanyaWaffles#5095
Twitch ID: sanyawaffles
Operating System: Windows 11
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 1 guest