[Fixed] Dynamic light binding issue not entirely fixed

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

Dynamic light binding issue not entirely fixed

Postby Player701 » Sun Sep 26, 2021 1:01 am

It appears that this issue was not entirely fixed. For example, player classes with states marked Light(...) still don't work properly. Example code and PWAD below.

Code: Select allExpand view
class TestPlayer : DoomPlayer
{
    States
    {
        Melee:
            PLAY F 6 BRIGHT Light("ZOMBIEATK");
            Goto Missile;
    }
}

Works in GZDoom 4.6.1, broken in 4.7.0 and above (tested with g4.8pre-7-gb59554f31, which should contain the fix to the mentioned issue). To reproduce, load the attached WAD file, then go to any map and fire a weapon. A light should appear around the player, but it does not happen in recent versions.
You do not have the required permissions to view the files attached to this post.
User avatar
Player701
 
 
 
Joined: 13 May 2009
Location: Russia
Discord: Player701#8214
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Dynamic light binding issue not entirely fixed

Postby Player701 » Sun Sep 26, 2021 7:34 am

OK, sorry, it looks like this is a duplicate of this report, while I thought that the other report was actually a duplicate of the original issue that was fixed. Please close this.
User avatar
Player701
 
 
 
Joined: 13 May 2009
Location: Russia
Discord: Player701#8214
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Dynamic light binding issue not entirely fixed

Postby Graf Zahl » Sun Oct 03, 2021 7:44 am

fixed
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Dynamic light binding issue not entirely fixed

Postby Marisa Kirisame » Thu Oct 14, 2021 10:09 am

I'd like to reopen this by saying that it's far from fixed. Attached lights in an actor state now won't detach once that state passes.

Example to reproduce bug here. There are two lights blinking every two seconds. One starts on and one starts off. Normally, the light would be alternating properly, but once the second light goes bright, the light never turns off ever again.
User avatar
Marisa Kirisame
ZScript Crimester
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: 霧雨魔理沙#1666
Twitch ID: MarisaDOOM
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Dynamic light binding issue not entirely fixed

Postby Enjay » Thu Oct 14, 2021 10:54 am

I just noticed in Quake Champions : Doom Edition that the Quake grunt enemies, once they have fired a shot are permanently lit by a yellow dynamic light (even when they are dead). I'd started to dig inside the files but it looks like it's probably the same issue.
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: Dynamic light binding issue not entirely fixed

Postby Player701 » Thu Oct 14, 2021 11:13 am

Confirmed, same here, reproducible even with vanilla IWADs and lights.pk3.
User avatar
Player701
 
 
 
Joined: 13 May 2009
Location: Russia
Discord: Player701#8214
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Dynamic light binding issue not entirely fixed

Postby Enjay » Thu Oct 14, 2021 11:23 am

Player701 wrote:reproducible even with vanilla IWADs and lights.pk3.

Surely not with the vanilla actors though? I'm not seeing it with them - only with actors that have lights attached in their states - which the vanilla monsters don't have (they are allocated on GLDEFS).
User avatar
Enjay
Everyone is a moon, and has a dark side which he never shows to anybody. Twain
 
 
 
Joined: 15 Jul 2003
Location: Scotland

Re: Dynamic light binding issue not entirely fixed

Postby Player701 » Thu Oct 14, 2021 11:24 am

Oops, sorry, forgot I was autoloading a mod. Too much work today... :? Yes, it only happens with lights attached via states, sorry again.
User avatar
Player701
 
 
 
Joined: 13 May 2009
Location: Russia
Discord: Player701#8214
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Dynamic light binding issue not entirely fixed

Postby Graf Zahl » Tue Oct 19, 2021 12:58 am

Should be fixed now, but I won't be able to test it myself right now
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Dynamic light binding issue not entirely fixed

Postby Marisa Kirisame » Tue Oct 19, 2021 2:00 am

It does seem to be fixed, yes.
User avatar
Marisa Kirisame
ZScript Crimester
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: 霧雨魔理沙#1666
Twitch ID: MarisaDOOM
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: Dynamic light binding issue not entirely fixed

Postby Graf Zahl » Tue Oct 19, 2021 2:07 am

Ok, then I can finally do the 4.7.1 release this evening.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Dynamic light binding issue not entirely fixed

Postby Nash » Tue Oct 19, 2021 3:24 am

This is a fast fix and should be included: https://github.com/coelckers/gzdoom/pull/1490
User avatar
Nash
AKA Nash Muhandes! Twitter/Facebook/Youtube: nashmuhandes
 
 
 
Joined: 27 Oct 2003
Location: Kuala Lumpur, Malaysia
Twitch ID: nashmuhandes
Github ID: nashmuhandes

Re: Dynamic light binding issue not entirely fixed

Postby Graf Zahl » Tue Oct 19, 2021 3:44 am

Yes, absolutely.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: Dynamic light binding issue not entirely fixed

Postby drfrag » Tue Oct 19, 2021 6:57 am

What about this one? viewtopic.php?f=2&t=73421
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: Dynamic light binding issue not entirely fixed

Postby Graf Zahl » Tue Oct 19, 2021 7:43 am

That one is not a trivial fix and generally avoidable by reordering one's definitions. So it's of lower priority.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 1 guest