[Fixed] [g4.7.0pre-131-gc3772fe20]Action DooM 2 Reloaded Crashes

[PlayerLin]

AD2 Reloaded: viewtopic.php?f=19&t=73018

How to reproduce:
0. Get GZDooM g4.7.0pre-131-gc3772fe20 x64(not sure about x86).
1. Start Action DooM 2:UB by IWAD selector of GZDooM.
2. Start new game, select UB episode.
3. On the beginning of Map01, grab the Whiskey, drink or not drink it, no matter.
4. Use Alt. Attack(Secondary Fire) when holding the Whiskey bottle.

And BAM! GZDooM just crashed after switching kick and back to the bottle.

Official 4.6.1 and g4.7.0pre-101-g39513cf7a are fine, no crash, only the latest GZDooM build in DRDTeam SVN Build site triggered the crash.

[drfrag]

It's the commit with the HUD model tweaks. Crashes in the following line:

Code: Select all • Expand view

      FSpriteModelFrame *smf = FindModelFrame(psp->Caller->GetClass(), psp->GetSprite(), psp->GetFrame(), false);

psp->Caller is NULL.

[Marisa the Magician]

Seems to be the usual problem of a weapon removing itself from the inventory while still running its states...

I guess some safeguard is needed there, I'll check what I can do.

Edit: Pull request done.