[Fixed] ChangeLevel with an invalid name causes crash

[SPZ1]

It seems that the map name string has to have more than 8 characters to cause the crash.

[_mental_]

I would prefer to have a runnable sample instead of crash report, especially if this issue has 100% repro rate.

[_mental_]

Fixed here and there. None of them is related to number of characters in level's name though.

[drfrag]

Without a runnable sample i don't know if the legacy builds are affected.

[_mental_]

It does partially. Run the attached file with the following command line, and press Use until it returns to console.

Code: Select all • Expand view

-iwad doom2 -file change_level.pk3 +map map01 +puke 1

The process will crash on attempt to exit. You need this commit.

[drfrag]

Thanks, for me it doesn't crash.

[_mental_]

I tried with LZDoom 3.88, and it is certainly affected. There is an assertion failure before the crash in Debug build as well. If you don’t hit it, you’re doing something wrong.

[drfrag]

May be it's my compiler then i'll merge it.

[drfrag]

https://github.com/drfrag666/gzdoom/com ... 1e13dcb3b3