[Fixed] [ge63f3e394 +] A_SeekerMissile broken

[SanyaWaffles]

It appears in latest builds of GZDoom seeker missile functionality is completely broken when used on Weapons. A_SeekerMissile doesn't work, but the Revenant tracer functions does.

I tested this with the latest GZDoom - g2d0a876ab.

It seems to break around ge63f3e394, with some of the MBF21 changes.

ga9ad3d1fc works fine.

https://www.dropbox.com/s/1tbn1wha98v9e ... t.pk3?dl=1

Use the rocket launcher. It will give you a tracer-enabled seeker missile.

EDIT: Looks like someone else is having problems with it.

viewtopic.php?f=2&t=72804

[SanyaWaffles]

I'm bumping this. This is still an issue in 4.6.1 as it has not been fixed yet in any dev builds.

[drfrag]

The MBF21 additions are not in 4.6.1. Have you actually tried it?

[Lord Misfit]

Huh. They must've been removed before the 4.6.1 release without us noticing.

I did just boot up 4.6.1 and a similar issue I've had [which I also made a topic on over a week back w/ its own example map] isn't happening anymore in my test map example that I had submitted on my topic. I just wish someone had at least stated on one of our topics that the MBF stuff was temporarily[?] removed and that the issue was noticed and being looked into, or some kind of finality on it. I thought they hadn't even noticed either of our topics due to focus on other other features, and that they'd just let us know when something had changed. But yeah, to be fair, MBF stuff didn't show up on the 4.6.1 topic either. So for now at least, the issue is fixed[?] I suppose, or being looked at. o.o

[phantombeta]

Huh. They must've been removed before the 4.6.1 release without us noticing.

That's because they haven't been removed at all. 4.6.1 only includes a fairly small amount of specifically selected changes, most of them being bugfixes - the rest of the changes, like the MBF21 stuff, will come whenever 4.7.0 is released. The master branch of the repo wasn't touched.

[SanyaWaffles]

That is bizarre. I never pulled a specific branch other than master. I'm gonna try using 4.6.1 and see if the bug remains.

[SanyaWaffles]

Okay, I see what happened here.

I guess the dev team removed the MBF21 stuff from the 4.6.1 release and the 4.6.1 branch.

That said, it's still a problem in the master branch it seems.

Thanks for the clarification, I'm new to git and had no idea you could omit certain commits.

[Rachael]

What happened with 4.6.1 is exactly what Phantom said; the bug fixes from master were "cherry-picked" by hand on top of 4.6.0 and that is what built 4.6.1.

[SanyaWaffles]

So after trial and error, it seems Lord Misfit's theory might be right.

P_RoughMonsterSearch seems to take a FOV value now, and the A_SeekerMissile function doesn't pass that along.

I dunno how to fix this. If I had a lead, I'd be willing to supply a pull request to fix this.

[Graf Zahl]

fixed