[Fixed] [GZDoom 3.0.0+] BEX lumps don't change Doom II par times

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

[GZDoom 3.0.0+] BEX lumps don't change Doom II par times

Postby Yarn366 » Tue Jun 01, 2021 2:10 am

GZDoom supports loading par times from BEX lumps, but only for E#M# maps--not for MAP## maps for some reason. Only GZDoom 3.0.0 and later seem to be affected; version 2.4.0 reads par times for both formats as expected.

For instance, this lump sets the par time for E1M1 to 10 minutes, and it works in GZDoom:
Code: Select allExpand view
Patch File for DeHackEd v3.0
# Created with WhackEd4 1.2.4 BETA
# Note: Use the pound sign ('#') to start comment lines.

Doom version = 21
Patch format = 6


[PARS]
par 1 1 600



This lump does the same thing for MAP01, but it doesn't work in GZDoom 3.0.0+:
Code: Select allExpand view
Patch File for DeHackEd v3.0
# Created with WhackEd4 1.2.4 BETA
# Note: Use the pound sign ('#') to start comment lines.

Doom version = 21
Patch format = 6


[PARS]
par 1 600



I have attached a zip file containing these same lumps.
You do not have the required permissions to view the files attached to this post.
Yarn366
 
Joined: 02 Mar 2018

Re: [GZDoom 3.0.0+] BEX lumps don't change Doom II par times

Postby drfrag » Thu Jun 03, 2021 5:49 am

It says "Par for e1m6 changed to 0".
I've done some investigation and it has to be this commit: https://github.com/coelckers/gzdoom/com ... 78095ece83
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: [GZDoom 3.0.0+] BEX lumps don't change Doom II par times

Postby _mental_ » Thu Jun 03, 2021 7:52 am

Fixed.

Strange that no one noticed that for over four years. At first, I was thinking about replacing '\r' with '\0' in igets() function, but who knows what else this could break.
_mental_
 
 
 
Joined: 07 Aug 2011


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 0 guests