[Not a bug] 'bFriendly = true' does not reduce monster count

[Ichor]

If you use the decorate code 'A_ChangeFlag("FRIENDLY",1)', this will reduce the total monster count by one. However, if you use the ZScript code 'bFriendly = true' to do the same thing, then the total monster count will not be reduced. This will give you an extra monster that will not be accounted for if it died and you won't be able to get 100% kills.

Here is an example. The ZScript text contains TestMonster1 that uses 'bFriendly = true' after a few frames. The Decorate text uses TestMonster2 that uses 'A_ChangeFlag("FRIENDLY",1)' instead. Summon both to see the difference.

[m8f]

Well, you can always adjust total monster count manually by doing

Code: Select all • Expand view

level.total_monsters -= 1;

I think it's expected that changing actor flag doesn't have side effects like changing total monster count.

[Ichor]

Except I seem to remember a few years ago that it was changed to reduce monster count on purpose.

Oh yeah, there's a couple of threads here and here.

[Graf Zahl]

Yes, it does, but the global monster counter lives elsewhere. If you just change the flag the engine only toggles a variable, so you have to take care of the counter yourself.

[Ichor]

Ok, but it is strange how it works with one method but not with another.

[Graf Zahl]

There is no "other method". But if you just change a variable on an actor directly at run time this won't update other related variables. 'bFriendly = true;' is just a variable assignment - it calls no function that updates other state in the engine - all it does is setting bFriendly to true. The global monster counter is a separate variable.

ZScript has no concept of properties like C# or Objective-C where you can overload an assignment with a function call.

[Ichor]

Well, as long as there's a way to deal with the actual problem, I should be fine.

Actually, I just found out about A_ChangeCountFlags, which does exactly what I need.

[Blue Shadow]

There's now this, for whoever might need it.