[Fixed] WINDTHRUST + wind + underwater = crash

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

WINDTHRUST + wind + underwater = crash

Postby Player701 » Tue Mar 09, 2021 10:20 am

If a WINDTHRUST-enabled object is thrown into a Transfer_Heights-based deep water and the main sector has wind enabled (e.g. via Sector_SetWind), the game will crash. The crash happens here because player is null. It appears that the crash does not happen with 3D floor-based water.

Attached is a simple WAD to reproduce the issue. Just press the switch, and the game will crash as soon as the WINDTHRUST-enabled barrel reaches the water surface.

Tested in GZDoom 4.5.0 and g4.6pre-150-gb7bbfd4ef
You do not have the required permissions to view the files attached to this post.
User avatar
Player701
 
 
 
Joined: 13 May 2009
Location: Russia
Discord: Player701#8214
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: WINDTHRUST + wind + underwater = crash

Postby drfrag » Wed Mar 10, 2021 6:09 am

I've made a PR: https://github.com/coelckers/gzdoom/pull/1335
I don't think it's worth doing more sophisticated calculations to check if the thing is actually wading.
User avatar
drfrag
Os voy a romper a pedazos!
Vintage GZDoom Developer
 
Joined: 23 Apr 2004
Location: Spain
Discord: drfrag#3555
Github ID: drfrag666

Re: WINDTHRUST + wind + underwater = crash

Postby Graf Zahl » Wed Mar 10, 2021 6:38 am

That wind code is stupid as shit anyway, yeah no need to be more thorough for non-players.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 3 guests