[Addressed] [769d60a] Crash when loading any mod with models

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

[769d60a] Crash when loading any mod with models

Postby Marisa Kirisame » Thu Feb 25, 2021 8:28 am

Since this commit, any mod with 3D models I load will cause a segmentation fault. gdb tells me this is happening in the hw_PrecacheTexture function, but I can't get many more details about this, even with a debug build, other than it's in some call to FTextureID::GetIndex().

I've reproduced the crash with all my mods, and just to be sure it's not a .3d loader thing (and therefore my fault), I also tried and got it in ZRift and Hunter's Moon. On Gene-Tech and Total Chaos I got "Too many models" errors instead.

Reverting the commit makes these crashes go away, so I am 100% sure it's this.
User avatar
Marisa Kirisame
ZScript Crimester
 
 
 
Joined: 08 Feb 2008
Location: Vigo, Galicia
Discord: 霧雨魔理沙#1666
Twitch ID: magusmarisa
Github ID: OrdinaryMagician
Operating System: Other Linux 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: [769d60a] Crash when loading any mod with models

Postby Kizoky » Thu Feb 25, 2021 8:54 am

Can confirm
Getting the latest version of devbuild (as of this post) causes a crash with my mod that's using models
User avatar
Kizoky
I smell like gravity
 
Joined: 14 Nov 2011
Location: Around weirdos, I'm the biggest weirdo among them
Discord: Kizoky#0375
Operating System: Windows 10/8.1/8/201x 64-bit
Graphics Processor: nVidia with Vulkan support

Re: [769d60a] Crash when loading any mod with models

Postby Rachael » Thu Feb 25, 2021 8:59 am

Alright - I've reverted that commit for now, much as I think this feature really needs to be in the engine it's not worth keeping the master in an unstable state. When the PR is fixed it can be readded. (There were apparently other problems with it, too, like it loading the wrong textures)
User avatar
Rachael
Admin
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: ATI/AMD with Vulkan Support

Re: [769d60a] Crash when loading any mod with models

Postby Cherno » Thu Feb 25, 2021 10:15 am

I'm on it... Wish me luck :3:
User avatar
Cherno
 
Joined: 06 Dec 2016


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 2 guests