[Not a bug] I fixed the stereoscopic 3D display mode

[PaganRaven]

See here: viewtopic.php?f=54&t=70922&p=1176033#p1176033

old, crappy full 3d:
download/file.php?id=40082

New, good 3D
download/file.php?id=40088

Wilst thou lettest me commit this to ye olde github?

[wildweasel]

You should probably submit it as a Github Pull Request, so it'll be easier for the project maintainer to inspect and merge the changes.

[PaganRaven]

I should probably figure out how to not make y-axis scale down in "narrow" mode, or we should come to a consensus if this is a replacement, a new mode, or remove the "narrow" and "full" modes to just have this.

[Rachael]

This should be a new mode. Some people might want that "full 3d".

[Valken]

+1 want this as full 3d!

[PaganRaven]

How about we keep split full and split narrow, and this new mode is just plain "split"

[Gez]

Or "split letterboxed" perhaps.

[PaganRaven]

I made a github account, got gz_doom master and worked on this more. I successfully added it as an extra menu option. One thing, though; I can edit the menudef.txt to add "$OPTVAL_SBSLETTERBOX", but that's exactly how it will read in the menu ingame, because I don't know where you set the text that actually displays when you select it, so it defaults to that optionvalue string.

Code: Select all • Expand view

OptionValue VRMode
{
   0, "$OPTVAL_NORMAL"
   1, "$OPTVAL_GREENMAGENTA"
   2, "$OPTVAL_REDCYAN"
   9, "$OPTVAL_AMBERBLUE"
   3, "$OPTVAL_SBSFULL"
   4, "$OPTVAL_SBSNARROW"
   8, "$OPTVAL_SBSLETTERBOX"
   11, "$OPTVAL_TOPBOTTOM"
   12, "$OPTVAL_ROWINTERLEAVED"
   13, "$OPTVAL_COLUMNINTERLEAVED"
   14, "$OPTVAL_CHECKERBOARD"
   5, "$OPTVAL_LEFTEYE"
   6, "$OPTVAL_RIGHTEYE"
   7, "$OPTVAL_QUADBUFFERED"
}


I just need to get 8, "$OPTVAL_SBSLETTERBOX" to say "Side By Side Letterbox" on the menu and it will be ready for uploading

[Rachael]

Go ahead and make the pull request, letting us know either here or in the pull request is sufficient to get the string added, or if you plan to do this a lot you can request access to this document.

[PaganRaven]

It took me a while to understand how github works, but I made my pull request.