[Not a bug] I fixed the stereoscopic 3D display mode

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

I fixed the stereoscopic 3D display mode

Postby PaganRaven » Sun Dec 13, 2020 9:20 pm

See here: viewtopic.php?f=54&t=70922&p=1176033#p1176033

old, crappy full 3d:
download/file.php?id=40082

New, good 3D
download/file.php?id=40088

Wilst thou lettest me commit this to ye olde github?
User avatar
PaganRaven
Viking Warrior
 
Joined: 14 Oct 2005

Re: I fixed the stereoscopic 3D display mode

Postby wildweasel » Sun Dec 13, 2020 9:22 pm

You should probably submit it as a Github Pull Request, so it'll be easier for the project maintainer to inspect and merge the changes.
User avatar
wildweasel
change o' pace.
Moderator Team Lead
 
Joined: 15 Jul 2003

Re: I fixed the stereoscopic 3D display mode

Postby PaganRaven » Sun Dec 13, 2020 10:10 pm

I should probably figure out how to not make y-axis scale down in "narrow" mode, or we should come to a consensus if this is a replacement, a new mode, or remove the "narrow" and "full" modes to just have this.
User avatar
PaganRaven
Viking Warrior
 
Joined: 14 Oct 2005

Re: I fixed the stereoscopic 3D display mode

Postby Rachael » Sun Dec 13, 2020 10:19 pm

This should be a new mode. Some people might want that "full 3d".
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: I fixed the stereoscopic 3D display mode

Postby Valken » Mon Dec 14, 2020 2:38 am

+1 want this as full 3d!
Valken
 
Joined: 08 Jun 2015

Re: I fixed the stereoscopic 3D display mode

Postby PaganRaven » Mon Dec 14, 2020 1:30 pm

How about we keep split full and split narrow, and this new mode is just plain "split"
User avatar
PaganRaven
Viking Warrior
 
Joined: 14 Oct 2005

Re: I fixed the stereoscopic 3D display mode

Postby Gez » Mon Dec 14, 2020 1:56 pm

Or "split letterboxed" perhaps.
Gez
 
 
 
Joined: 06 Jul 2007

Re: I fixed the stereoscopic 3D display mode

Postby PaganRaven » Sun Dec 20, 2020 8:07 pm

I made a github account, got gz_doom master and worked on this more. I successfully added it as an extra menu option. One thing, though; I can edit the menudef.txt to add "$OPTVAL_SBSLETTERBOX", but that's exactly how it will read in the menu ingame, because I don't know where you set the text that actually displays when you select it, so it defaults to that optionvalue string.

Code: Select allExpand view
OptionValue VRMode
{
   0, "$OPTVAL_NORMAL"
   1, "$OPTVAL_GREENMAGENTA"
   2, "$OPTVAL_REDCYAN"
   9, "$OPTVAL_AMBERBLUE"
   3, "$OPTVAL_SBSFULL"
   4, "$OPTVAL_SBSNARROW"
   8, "$OPTVAL_SBSLETTERBOX"
   11, "$OPTVAL_TOPBOTTOM"
   12, "$OPTVAL_ROWINTERLEAVED"
   13, "$OPTVAL_COLUMNINTERLEAVED"
   14, "$OPTVAL_CHECKERBOARD"
   5, "$OPTVAL_LEFTEYE"
   6, "$OPTVAL_RIGHTEYE"
   7, "$OPTVAL_QUADBUFFERED"
}


I just need to get 8, "$OPTVAL_SBSLETTERBOX" to say "Side By Side Letterbox" on the menu and it will be ready for uploading
User avatar
PaganRaven
Viking Warrior
 
Joined: 14 Oct 2005

Re: I fixed the stereoscopic 3D display mode

Postby Rachael » Sun Dec 20, 2020 8:24 pm

Go ahead and make the pull request, letting us know either here or in the pull request is sufficient to get the string added, or if you plan to do this a lot you can request access to this document.
User avatar
Rachael
Webmaster
 
Joined: 13 Jan 2004
Discord: Rachael#3767
Twitch ID: madamerachelle
Github ID: madame-rachelle
Operating System: Windows 10/8.1/8/201x 64-bit
OS Test Version: No (Using Stable Public Version)
Graphics Processor: nVidia with Vulkan support

Re: I fixed the stereoscopic 3D display mode

Postby PaganRaven » Wed Dec 23, 2020 4:40 pm

It took me a while to understand how github works, but I made my pull request.
User avatar
PaganRaven
Viking Warrior
 
Joined: 14 Oct 2005


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 3 guests