[Fixed] [3.87b] LevelLocals.ChangeLevel() doesn't change level

[m8f]

Steps to reproduce:
1. load

lzdoom-change-level.pk3

2. Start Doom II game.
3. Type in console "netevent lcl_test".

Expected behavior: intermission is displayed, then map02 starts.
Actual behavior: intermission is displayed, then clustertext "You have entered deeply into infested starport..." is displayed, then map01 starts again.

The bug was discovered when testing this library with LZDoom. There, the actual behavior is different. Instead of moving the player to the special "headquarters" map, the game drops to console and the following message is displayed:

Code: Select all • Expand view

|ò - Unnamed

Unable to open map '|ò'

The text between quotes is different every time, looks like garbage memory.

[Rachael]

Sounds like a single (but critical) variable isn't being initialized with the function call.

[drfrag]

Too bad it doesn't work. FLevelLocals::ChangeLevel was exported recently to ZScript and in LZDoom it didn't exist so i exported G_ChangeLevel instead, I left the level refactor out becouse in theory it wasn't important. So i'm afraid this will have to wait for the 4.5 release.
Edit: actually i made a stupid mistake but it doesn't work anyway.

[drfrag]

I don't know why it doesn't work, it's the old setup. I merged a couple of commits and that broke everything, i managed to fix it but i was not sure (better safe than sorry) so i reverted everything. One said "wminfo has been made a local variable in G_DoCompleted. There were two places where this was accessed from outside the summary screen or its setup code, and both were incorrect." and the other "The wbstartstruct that gets passed to the level summary screen needs to be static". It was the "allow the language table to supersede the title patches, if appropriate" thing.
So now it gets here and i get that message:

Code: Select all • Expand view

void G_DoWorldDone (void)
{      
   gamestate = GS_LEVEL;
   if (wminfo.next[0] == 0)
   {
      // Don't crash if no next map is given. Just repeat the current one.
      Printf ("No next map specified.\n");
   }


I think trying to fix this is risky, if someone wants to help that's another thing. Seems that G_ChangeLevel() was already broken.

[drfrag]

With this change the map name is junk and says "Unable to open map":
diff --git a/src/g_level.cpp b/src/g_level.cpp

Code: Select all • Expand view

index 659497c0b..ea81a9391 100644
--- a/src/g_level.cpp
+++ b/src/g_level.cpp
@@ -1319,7 +1319,7 @@ DEFINE_ACTION_FUNCTION(FLevelLocals, WorldDone)
 void G_DoWorldDone (void)
 {      
    gamestate = GS_LEVEL;
-   if (wminfo.next[0] == 0)
+   if (nextlevel.IsEmpty())
    {
       // Don't crash if no next map is given. Just repeat the current one.
       Printf ("No next map specified.\n");


[drfrag]

Now that i'm at it debugging i see that levelname is junk from the start, i can't see anything wrong with the export:

Code: Select all • Expand view

void G_ChangeLevel(const char *levelname, int position, int flags, int nextSkill);

DEFINE_ACTION_FUNCTION_NATIVE(FLevelLocals, ChangeLevel, G_ChangeLevel)
{
   PARAM_PROLOGUE;
   PARAM_STRING(levelname);
   PARAM_INT(position);
   PARAM_INT(inflags);
   PARAM_INT(nextSkill);
   G_ChangeLevel(levelname, position, inflags, nextSkill);
   return 0;
}

native static void ChangeLevel(string levelname, int position = 0, int flags = 0, int skill = -1);

[drfrag]

Fixed thanks to phantombeta.
https://github.com/drfrag666/gzdoom/com ... e896735885