[Can't fix] [4.5.0] LOOP_BIDI seems to be non-functional

Bugs that have been investigated and resolved somehow.

Moderator: GZDoom Developers

[4.5.0] LOOP_BIDI seems to be non-functional

Postby Kinsie » Sun Dec 06, 2020 8:58 am

Quoting a teammate:
Quick check, does GZDoom no longer support bidirectional audio looping? LOOP_BIDI doesn't seem to work anymore and the LOOP_MIDI tag seems to be totally missing from the source code
User avatar
Kinsie
Dog Days
 
Joined: 22 Oct 2004
Location: MAP33
Discord: Find Me...
Twitch ID: thekinsie

Re: [4.5.0] LOOP_BIDI seems to be non-functional

Postby TheShadsy » Sun Dec 06, 2020 4:40 pm

Hi, I'm the teammate! (also that was a typo, that should've said LOOP_BIDI, not MIDI)

But yes, I've noticed that LOOP_BIDI doesn't seem to be working when using A_StartSound with CHANF_LOOP. LOOP_START and LOOP_END are still honored, though. I tried this with both .ogg and .flac files and didn't notice any difference.

I've attached a sample sound with a LOOP_BIDI tag. It should be obvious that playback is being reversed, but the sound just restarts. Have I missed something, or is this feature having issues?
You do not have the required permissions to view the files attached to this post.
TheShadsy
 
Joined: 15 Apr 2012

Re: [4.5.0] LOOP_BIDI seems to be non-functional

Postby Graf Zahl » Sun Dec 06, 2020 5:06 pm

Loop_BIDI was an FModEx feature - it got removed along with that backend.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany

Re: [4.5.0] LOOP_BIDI seems to be non-functional

Postby Gez » Sun Dec 06, 2020 5:25 pm

So it'd be up to chris to implement the functionality in OpenAL and then it could be restored?
Gez
 
 
 
Joined: 06 Jul 2007

Re: [4.5.0] LOOP_BIDI seems to be non-functional

Postby Chris » Sun Dec 06, 2020 6:52 pm

IIRC, it wasn't a particularly cared-about feature, either in general for an audio library or for ZDoom itself. It could also pose a problem for a future enhancement I might do with OpenAL, that being direct ADPCM support in the mixer (it's a block-based adaptive codec that's nearly 4x smaller than 16-bit samples with relatively little quality loss, where samples depend on the decoder state from previous decoded samples; needing to read samples in reverse would create an obvious complication). A sound author that wants it could bake the reversed section into the sound and set the loop point on the backward and forward section to get the same effect.
User avatar
Chris
 
Joined: 17 Jul 2003

Re: [4.5.0] LOOP_BIDI seems to be non-functional

Postby TheShadsy » Sun Dec 06, 2020 7:13 pm

Chris wrote:IIRC, it wasn't a particularly cared-about feature, either in general for an audio library or for ZDoom itself. It could also pose a problem for a future enhancement I might do with OpenAL, that being direct ADPCM support in the mixer (it's a block-based adaptive codec that's nearly 4x smaller than 16-bit samples with relatively little quality loss, where samples depend on the decoder state from previous decoded samples; needing to read samples in reverse would create an obvious complication). A sound author that wants it could bake the reversed section into the sound and set the loop point on the backward and forward section to get the same effect.

Somehow that hadn't even occurred to me, for whatever reason. That'll work; thanks for the clarification everyone!

And Gez, thank you for updating the wiki! I was just about to ask about that.
TheShadsy
 
Joined: 15 Apr 2012

Re: [4.5.0] LOOP_BIDI seems to be non-functional

Postby Graf Zahl » Mon Dec 07, 2020 1:00 am

Chris wrote:IIRC, it wasn't a particularly cared-about feature, either in general for an audio library or for ZDoom itself.


It obviously wasn't. It got removed along with FMod more than 3.5 years ago and this is the first time it ever came up.
User avatar
Graf Zahl
Lead GZDoom+Raze Developer
Lead GZDoom+Raze Developer
 
Joined: 19 Jul 2003
Location: Germany


Return to Closed Bugs

Who is online

Users browsing this forum: No registered users and 0 guests